Commit bb6f99c1 authored by Shankara Pailoor's avatar Shankara Pailoor Committed by Stefan Bader

jfs: Fix inconsistency between memory allocation and ea_buf->max_size

CVE-2018-12233

The code is assuming the buffer is max_size length, but we weren't
allocating enough space for it.
Signed-off-by: default avatarShankara Pailoor <shankarapailoor@gmail.com>
Signed-off-by: default avatarDave Kleikamp <dave.kleikamp@oracle.com>
(cherry picked from commit 92d34134)
Signed-off-by: default avatarPaolo Pisati <paolo.pisati@canonical.com>
Acked-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
Acked-by: default avatarStefan Bader <stefan.bader@canonical.com>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
parent 858395eb
...@@ -493,15 +493,17 @@ static int ea_get(struct inode *inode, struct ea_buffer *ea_buf, int min_size) ...@@ -493,15 +493,17 @@ static int ea_get(struct inode *inode, struct ea_buffer *ea_buf, int min_size)
if (size > PSIZE) { if (size > PSIZE) {
/* /*
* To keep the rest of the code simple. Allocate a * To keep the rest of the code simple. Allocate a
* contiguous buffer to work with * contiguous buffer to work with. Make the buffer large
* enough to make use of the whole extent.
*/ */
ea_buf->xattr = kmalloc(size, GFP_KERNEL); ea_buf->max_size = (size + sb->s_blocksize - 1) &
~(sb->s_blocksize - 1);
ea_buf->xattr = kmalloc(ea_buf->max_size, GFP_KERNEL);
if (ea_buf->xattr == NULL) if (ea_buf->xattr == NULL)
return -ENOMEM; return -ENOMEM;
ea_buf->flag = EA_MALLOC; ea_buf->flag = EA_MALLOC;
ea_buf->max_size = (size + sb->s_blocksize - 1) &
~(sb->s_blocksize - 1);
if (ea_size == 0) if (ea_size == 0)
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment