Commit bc06cfc1 authored by Tian Tao's avatar Tian Tao Committed by Alexandre Belloni

rtc: cpcap: Fix missing IRQF_ONESHOT as only threaded handler

Coccinelle noticed:
drivers/rtc/rtc-cpcap.c:271:7-32: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT
drivers/rtc/rtc-cpcap.c:287:7-32: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT
Signed-off-by: default avatarTian Tao <tiantao6@hisilicon.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/1605000947-32882-1-git-send-email-tiantao6@hisilicon.com
parent c56ac7a0
...@@ -269,7 +269,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev) ...@@ -269,7 +269,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
rtc->alarm_irq = platform_get_irq(pdev, 0); rtc->alarm_irq = platform_get_irq(pdev, 0);
err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL, err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE, cpcap_rtc_alarm_irq,
IRQF_TRIGGER_NONE | IRQF_ONESHOT,
"rtc_alarm", rtc); "rtc_alarm", rtc);
if (err) { if (err) {
dev_err(dev, "Could not request alarm irq: %d\n", err); dev_err(dev, "Could not request alarm irq: %d\n", err);
...@@ -285,7 +286,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev) ...@@ -285,7 +286,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
*/ */
rtc->update_irq = platform_get_irq(pdev, 1); rtc->update_irq = platform_get_irq(pdev, 1);
err = devm_request_threaded_irq(dev, rtc->update_irq, NULL, err = devm_request_threaded_irq(dev, rtc->update_irq, NULL,
cpcap_rtc_update_irq, IRQF_TRIGGER_NONE, cpcap_rtc_update_irq,
IRQF_TRIGGER_NONE | IRQF_ONESHOT,
"rtc_1hz", rtc); "rtc_1hz", rtc);
if (err) { if (err) {
dev_err(dev, "Could not request update irq: %d\n", err); dev_err(dev, "Could not request update irq: %d\n", err);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment