Commit bc87bb34 authored by Aleksandr Burakov's avatar Aleksandr Burakov Committed by Helge Deller

fbdev: viafb: fix typo in hw_bitblt_1 and hw_bitblt_2

There are some actions with value 'tmp' but 'dst_addr' is checked instead.
It is obvious that a copy-paste error was made here and the value
of variable 'tmp' should be checked here.

Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: default avatarAleksandr Burakov <a.burakov@rosalinux.ru>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 97419172
...@@ -115,7 +115,7 @@ static int hw_bitblt_1(void __iomem *engine, u8 op, u32 width, u32 height, ...@@ -115,7 +115,7 @@ static int hw_bitblt_1(void __iomem *engine, u8 op, u32 width, u32 height,
if (op != VIA_BITBLT_FILL) { if (op != VIA_BITBLT_FILL) {
tmp = src_mem ? 0 : src_addr; tmp = src_mem ? 0 : src_addr;
if (dst_addr & 0xE0000007) { if (tmp & 0xE0000007) {
printk(KERN_WARNING "hw_bitblt_1: Unsupported source " printk(KERN_WARNING "hw_bitblt_1: Unsupported source "
"address %X\n", tmp); "address %X\n", tmp);
return -EINVAL; return -EINVAL;
...@@ -260,7 +260,7 @@ static int hw_bitblt_2(void __iomem *engine, u8 op, u32 width, u32 height, ...@@ -260,7 +260,7 @@ static int hw_bitblt_2(void __iomem *engine, u8 op, u32 width, u32 height,
writel(tmp, engine + 0x18); writel(tmp, engine + 0x18);
tmp = src_mem ? 0 : src_addr; tmp = src_mem ? 0 : src_addr;
if (dst_addr & 0xE0000007) { if (tmp & 0xE0000007) {
printk(KERN_WARNING "hw_bitblt_2: Unsupported source " printk(KERN_WARNING "hw_bitblt_2: Unsupported source "
"address %X\n", tmp); "address %X\n", tmp);
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment