Commit bdd4034d authored by Rabin Vincent's avatar Rabin Vincent Committed by Greg Kroah-Hartman

driver core: always handle dpm_order

If !dev->class, device_move() does not respect the dpm_order.
Fix it to do so.
Acked-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: default avatarRabin Vincent <rabin.vincent@stericsson.com>
Reviewed-by: default avatarSrinidhi Kasagar <srinidhi.kasagar@stericsson.com>
[Fixed a small dangling label compile warning]
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cfaf0251
...@@ -1754,8 +1754,7 @@ int device_move(struct device *dev, struct device *new_parent, ...@@ -1754,8 +1754,7 @@ int device_move(struct device *dev, struct device *new_parent,
set_dev_node(dev, dev_to_node(new_parent)); set_dev_node(dev, dev_to_node(new_parent));
} }
if (!dev->class) if (dev->class) {
goto out_put;
error = device_move_class_links(dev, old_parent, new_parent); error = device_move_class_links(dev, old_parent, new_parent);
if (error) { if (error) {
/* We ignore errors on cleanup since we're hosed anyway... */ /* We ignore errors on cleanup since we're hosed anyway... */
...@@ -1774,6 +1773,7 @@ int device_move(struct device *dev, struct device *new_parent, ...@@ -1774,6 +1773,7 @@ int device_move(struct device *dev, struct device *new_parent,
put_device(new_parent); put_device(new_parent);
goto out; goto out;
} }
}
switch (dpm_order) { switch (dpm_order) {
case DPM_ORDER_NONE: case DPM_ORDER_NONE:
break; break;
...@@ -1787,7 +1787,7 @@ int device_move(struct device *dev, struct device *new_parent, ...@@ -1787,7 +1787,7 @@ int device_move(struct device *dev, struct device *new_parent,
device_pm_move_last(dev); device_pm_move_last(dev);
break; break;
} }
out_put:
put_device(old_parent); put_device(old_parent);
out: out:
device_pm_unlock(); device_pm_unlock();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment