Commit c13d2ad0 authored by Roland Vossen's avatar Roland Vossen Committed by Greg Kroah-Hartman

staging: brcm80211: bugfix for fifo problem on 64 bits platforms.

Message 'receive fifo overflow' appeared in the log. Root cause was an
invalid physical address being programmed into the DMA engine. This was
caused by an invalid pointer cast in the dma code. Issue was observed on
a Sparc (Sun Fire V120) machine but could theoretically also pop up
on other architectures.

Driver was tested to scan and ping on aforementioned machine.
Reviewed-by: default avatarArend van Spriel <arend@broadcom.com>
Reviewed-by: default avatarPieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: default avatarArend van Spriel <arend@broadcom.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 49d468f6
...@@ -600,13 +600,18 @@ static bool _dma_alloc(struct dma_info *di, uint direction) ...@@ -600,13 +600,18 @@ static bool _dma_alloc(struct dma_info *di, uint direction)
void *dma_alloc_consistent(struct pci_dev *pdev, uint size, u16 align_bits, void *dma_alloc_consistent(struct pci_dev *pdev, uint size, u16 align_bits,
uint *alloced, unsigned long *pap) uint *alloced, unsigned long *pap)
{ {
void *rc;
dma_addr_t dma_addr;
if (align_bits) { if (align_bits) {
u16 align = (1 << align_bits); u16 align = (1 << align_bits);
if (!IS_ALIGNED(PAGE_SIZE, align)) if (!IS_ALIGNED(PAGE_SIZE, align))
size += align; size += align;
*alloced = size; *alloced = size;
} }
return pci_alloc_consistent(pdev, size, (dma_addr_t *) pap); rc = pci_alloc_consistent(pdev, size, &dma_addr);
*pap = dma_addr;
return rc;
} }
/* !! may be called with core in reset */ /* !! may be called with core in reset */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment