Commit c2b8bd49 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by David Howells

afs: Use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with
memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent a88cc8da
...@@ -42,9 +42,7 @@ struct afs_server_list *afs_alloc_server_list(struct afs_cell *cell, ...@@ -42,9 +42,7 @@ struct afs_server_list *afs_alloc_server_list(struct afs_cell *cell,
if (vldb->fs_mask[i] & type_mask) if (vldb->fs_mask[i] & type_mask)
nr_servers++; nr_servers++;
slist = kzalloc(sizeof(struct afs_server_list) + slist = kzalloc(struct_size(slist, servers, nr_servers), GFP_KERNEL);
sizeof(struct afs_server_entry) * nr_servers,
GFP_KERNEL);
if (!slist) if (!slist)
goto error; goto error;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment