Commit c34c78df authored by Yunfeng Ye's avatar Yunfeng Ye Committed by Paul Moore

audit: remove redundant condition check in kauditd_thread()

Warning is found by the code analysis tool:
  "the condition 'if(ac && rc < 0)' is redundant: ac"

The @ac variable has been checked before. It can't be a null pointer
here, so remove the redundant condition check.
Signed-off-by: default avatarYunfeng Ye <yeyunfeng@huawei.com>
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
parent 245d7369
...@@ -830,7 +830,7 @@ static int kauditd_thread(void *dummy) ...@@ -830,7 +830,7 @@ static int kauditd_thread(void *dummy)
rc = kauditd_send_queue(sk, portid, rc = kauditd_send_queue(sk, portid,
&audit_hold_queue, UNICAST_RETRIES, &audit_hold_queue, UNICAST_RETRIES,
NULL, kauditd_rehold_skb); NULL, kauditd_rehold_skb);
if (ac && rc < 0) { if (rc < 0) {
sk = NULL; sk = NULL;
auditd_reset(ac); auditd_reset(ac);
goto main_queue; goto main_queue;
...@@ -840,7 +840,7 @@ static int kauditd_thread(void *dummy) ...@@ -840,7 +840,7 @@ static int kauditd_thread(void *dummy)
rc = kauditd_send_queue(sk, portid, rc = kauditd_send_queue(sk, portid,
&audit_retry_queue, UNICAST_RETRIES, &audit_retry_queue, UNICAST_RETRIES,
NULL, kauditd_hold_skb); NULL, kauditd_hold_skb);
if (ac && rc < 0) { if (rc < 0) {
sk = NULL; sk = NULL;
auditd_reset(ac); auditd_reset(ac);
goto main_queue; goto main_queue;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment