Commit c37a192e authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

Staging: Gasket: shift wrapping bug in gasket_read_modify_write_64()

This function only has one caller so mask_width is 1 and mask_shift is
32.  Shifting an int by 32 bits is undefined, but I guess on GCC it
wraps to 0x1?  Anyway it's supposed to be 0x100000000.

Fixes: 9a69f508 ("drivers/staging: Gasket driver framework + Apex driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7cc6dfd0
......@@ -683,7 +683,7 @@ static inline void gasket_read_modify_write_64(
u64 mask, tmp;
tmp = gasket_dev_read_64(dev, bar, location);
mask = ((1 << mask_width) - 1) << mask_shift;
mask = ((1ULL << mask_width) - 1) << mask_shift;
tmp = (tmp & ~mask) | (value << mask_shift);
gasket_dev_write_64(dev, tmp, bar, location);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment