Commit c3c589ed authored by Oliver Neukum's avatar Oliver Neukum Committed by Luis Henriques

cdc-acm: memory leak in error case

commit d908f847 upstream.

If probe() fails not only the attributes need to be removed
but also the memory freed.
Reported-by: default avatarAhmed Tamrawi <ahmedtamrawi@gmail.com>
Signed-off-by: default avatarOliver Neukum <oneukum@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 465ec8f3
...@@ -1470,6 +1470,7 @@ static int acm_probe(struct usb_interface *intf, ...@@ -1470,6 +1470,7 @@ static int acm_probe(struct usb_interface *intf,
&dev_attr_wCountryCodes); &dev_attr_wCountryCodes);
device_remove_file(&acm->control->dev, device_remove_file(&acm->control->dev,
&dev_attr_iCountryCodeRelDate); &dev_attr_iCountryCodeRelDate);
kfree(acm->country_codes);
} }
device_remove_file(&acm->control->dev, &dev_attr_bmCapabilities); device_remove_file(&acm->control->dev, &dev_attr_bmCapabilities);
alloc_fail7: alloc_fail7:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment