Commit c511fa3f authored by Alexey Klimov's avatar Alexey Klimov Committed by Sudeep Holla

firmware: arm_scpi: reinit completion instead of full init_completion()

Instead of performing full initialization of the completion structure
on each transfer in scpi_send_message(), we initialize it at boot time
(more specifically, in the relevant probe() function) and use
reinit_completion() to reset ->done counter on each message transfer.
Signed-off-by: default avatarAlexey Klimov <alexey.klimov@arm.com>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent c1ae3cfa
...@@ -538,7 +538,7 @@ static int scpi_send_message(u8 idx, void *tx_buf, unsigned int tx_len, ...@@ -538,7 +538,7 @@ static int scpi_send_message(u8 idx, void *tx_buf, unsigned int tx_len,
msg->tx_len = tx_len; msg->tx_len = tx_len;
msg->rx_buf = rx_buf; msg->rx_buf = rx_buf;
msg->rx_len = rx_len; msg->rx_len = rx_len;
init_completion(&msg->done); reinit_completion(&msg->done);
ret = mbox_send_message(scpi_chan->chan, msg); ret = mbox_send_message(scpi_chan->chan, msg);
if (ret < 0 || !rx_buf) if (ret < 0 || !rx_buf)
...@@ -872,8 +872,11 @@ static int scpi_alloc_xfer_list(struct device *dev, struct scpi_chan *ch) ...@@ -872,8 +872,11 @@ static int scpi_alloc_xfer_list(struct device *dev, struct scpi_chan *ch)
return -ENOMEM; return -ENOMEM;
ch->xfers = xfers; ch->xfers = xfers;
for (i = 0; i < MAX_SCPI_XFERS; i++, xfers++) for (i = 0; i < MAX_SCPI_XFERS; i++, xfers++) {
init_completion(&xfers->done);
list_add_tail(&xfers->node, &ch->xfers_list); list_add_tail(&xfers->node, &ch->xfers_list);
}
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment