Commit c545a257 authored by Kees Cook's avatar Kees Cook Committed by Stefan Bader

video: uvesafb: Fix integer overflow in allocation

BugLink: https://bugs.launchpad.net/bugs/1784382

commit 9f645bcc upstream.

cmap->len can get close to INT_MAX/2, allowing for an integer overflow in
allocation. This uses kmalloc_array() instead to catch the condition.
Reported-by: default avatarDr Silvio Cesare of InfoSect <silvio.cesare@gmail.com>
Fixes: 8bdb3a2d ("uvesafb: the driver core")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
parent 675f86fd
...@@ -1059,7 +1059,8 @@ static int uvesafb_setcmap(struct fb_cmap *cmap, struct fb_info *info) ...@@ -1059,7 +1059,8 @@ static int uvesafb_setcmap(struct fb_cmap *cmap, struct fb_info *info)
info->cmap.len || cmap->start < info->cmap.start) info->cmap.len || cmap->start < info->cmap.start)
return -EINVAL; return -EINVAL;
entries = kmalloc(sizeof(*entries) * cmap->len, GFP_KERNEL); entries = kmalloc_array(cmap->len, sizeof(*entries),
GFP_KERNEL);
if (!entries) if (!entries)
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment