Commit c588f7d6 authored by Stephen Boyd's avatar Stephen Boyd Committed by Abhinav Kumar

drm/msm: Add newlines to some debug prints

These debug prints are missing newlines, leading to multiple messages
being printed on one line and hard to read logs. Add newlines to have
the debug prints on separate lines. The DBG macro used to add a newline,
but I missed that while migrating to drm_dbg wrappers.

Fixes: 7cb017db ("drm/msm: Move FB debug prints to drm_dbg_state()")
Fixes: 721c6e0c ("drm/msm: Move vblank debug prints to drm_dbg_vbl()")
Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/584769/
Link: https://lore.kernel.org/r/20240325210810.1340820-1-swboyd@chromium.orgSigned-off-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
parent e86750b0
...@@ -89,7 +89,7 @@ int msm_framebuffer_prepare(struct drm_framebuffer *fb, ...@@ -89,7 +89,7 @@ int msm_framebuffer_prepare(struct drm_framebuffer *fb,
for (i = 0; i < n; i++) { for (i = 0; i < n; i++) {
ret = msm_gem_get_and_pin_iova(fb->obj[i], aspace, &msm_fb->iova[i]); ret = msm_gem_get_and_pin_iova(fb->obj[i], aspace, &msm_fb->iova[i]);
drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)", drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)\n",
fb->base.id, i, msm_fb->iova[i], ret); fb->base.id, i, msm_fb->iova[i], ret);
if (ret) if (ret)
return ret; return ret;
...@@ -176,7 +176,7 @@ static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev, ...@@ -176,7 +176,7 @@ static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev,
const struct msm_format *format; const struct msm_format *format;
int ret, i, n; int ret, i, n;
drm_dbg_state(dev, "create framebuffer: mode_cmd=%p (%dx%d@%4.4s)", drm_dbg_state(dev, "create framebuffer: mode_cmd=%p (%dx%d@%4.4s)\n",
mode_cmd, mode_cmd->width, mode_cmd->height, mode_cmd, mode_cmd->width, mode_cmd->height,
(char *)&mode_cmd->pixel_format); (char *)&mode_cmd->pixel_format);
...@@ -232,7 +232,7 @@ static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev, ...@@ -232,7 +232,7 @@ static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev,
refcount_set(&msm_fb->dirtyfb, 1); refcount_set(&msm_fb->dirtyfb, 1);
drm_dbg_state(dev, "create: FB ID: %d (%p)", fb->base.id, fb); drm_dbg_state(dev, "create: FB ID: %d (%p)\n", fb->base.id, fb);
return fb; return fb;
......
...@@ -149,7 +149,7 @@ int msm_crtc_enable_vblank(struct drm_crtc *crtc) ...@@ -149,7 +149,7 @@ int msm_crtc_enable_vblank(struct drm_crtc *crtc)
struct msm_kms *kms = priv->kms; struct msm_kms *kms = priv->kms;
if (!kms) if (!kms)
return -ENXIO; return -ENXIO;
drm_dbg_vbl(dev, "crtc=%u", crtc->base.id); drm_dbg_vbl(dev, "crtc=%u\n", crtc->base.id);
return vblank_ctrl_queue_work(priv, crtc, true); return vblank_ctrl_queue_work(priv, crtc, true);
} }
...@@ -160,7 +160,7 @@ void msm_crtc_disable_vblank(struct drm_crtc *crtc) ...@@ -160,7 +160,7 @@ void msm_crtc_disable_vblank(struct drm_crtc *crtc)
struct msm_kms *kms = priv->kms; struct msm_kms *kms = priv->kms;
if (!kms) if (!kms)
return; return;
drm_dbg_vbl(dev, "crtc=%u", crtc->base.id); drm_dbg_vbl(dev, "crtc=%u\n", crtc->base.id);
vblank_ctrl_queue_work(priv, crtc, false); vblank_ctrl_queue_work(priv, crtc, false);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment