Commit c778edb5 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab

[media] mxl111sf: don't redefine pr_err/info/debug

Remove the silly redefines of pr_err/info/debug.
This improves readability and it also gets rid of a bunch of warnings when
compiling this driver for older kernels using the compatibility media_build
system.
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent bbf94616
...@@ -31,8 +31,6 @@ MODULE_PARM_DESC(debug, "set debugging level (1=info (or-able))."); ...@@ -31,8 +31,6 @@ MODULE_PARM_DESC(debug, "set debugging level (1=info (or-able)).");
if (mxl111sf_tuner_debug) \ if (mxl111sf_tuner_debug) \
mxl_printk(KERN_DEBUG, fmt, ##arg) mxl_printk(KERN_DEBUG, fmt, ##arg)
#define err pr_err
/* ------------------------------------------------------------------------ */ /* ------------------------------------------------------------------------ */
struct mxl111sf_tuner_state { struct mxl111sf_tuner_state {
...@@ -113,7 +111,7 @@ static struct mxl111sf_reg_ctrl_info *mxl111sf_calc_phy_tune_regs(u32 freq, ...@@ -113,7 +111,7 @@ static struct mxl111sf_reg_ctrl_info *mxl111sf_calc_phy_tune_regs(u32 freq,
filt_bw = 63; filt_bw = 63;
break; break;
default: default:
err("%s: invalid bandwidth setting!", __func__); pr_err("%s: invalid bandwidth setting!", __func__);
return NULL; return NULL;
} }
...@@ -304,12 +302,12 @@ static int mxl111sf_tuner_set_params(struct dvb_frontend *fe) ...@@ -304,12 +302,12 @@ static int mxl111sf_tuner_set_params(struct dvb_frontend *fe)
bw = 8; bw = 8;
break; break;
default: default:
err("%s: bandwidth not set!", __func__); pr_err("%s: bandwidth not set!", __func__);
return -EINVAL; return -EINVAL;
} }
break; break;
default: default:
err("%s: modulation type not supported!", __func__); pr_err("%s: modulation type not supported!", __func__);
return -EINVAL; return -EINVAL;
} }
ret = mxl1x1sf_tune_rf(fe, c->frequency, bw); ret = mxl1x1sf_tune_rf(fe, c->frequency, bw);
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment