Commit ce47f52f authored by Andy Grover's avatar Andy Grover

RDS: Update comments in rds_send_xmit()

Update comments to reflect changes in previous commit.

Keeping as separate commits due to different authorship.
Signed-off-by: default avatarAndy Grover <andy.grover@oracle.com>
parent 9e29db0e
...@@ -353,15 +353,14 @@ int rds_send_xmit(struct rds_connection *conn) ...@@ -353,15 +353,14 @@ int rds_send_xmit(struct rds_connection *conn)
/* /*
* Other senders will see we have c_send_lock and exit. We * Other senders will see we have c_send_lock and exit. We
* need to recheck the send queue and race again for c_send_lock * need to recheck the send queue and race again for c_send_lock
* to make sure messages don't just sit on the send queue. * to make sure messages don't just sit on the send queue, if
* somebody hasn't already beat us into the loop.
* *
* If the transport cannot continue (i.e ret != 0), then it must * If the transport cannot continue (i.e ret != 0), then it must
* call us when more room is available, such as from the tx * call us when more room is available, such as from the tx
* completion handler. * completion handler.
*/ */
if (ret == 0) { if (ret == 0) {
/* A simple bit test would be way faster than taking the
* spin lock */
smp_mb(); smp_mb();
if (!list_empty(&conn->c_send_queue)) { if (!list_empty(&conn->c_send_queue)) {
rds_stats_inc(s_send_lock_queue_raced); rds_stats_inc(s_send_lock_queue_raced);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment