Commit d0aa558c authored by Takashi Iwai's avatar Takashi Iwai

ALSA: hiface: Use managed buffer allocation

Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and got
dropped.

Link: https://lore.kernel.org/r/20191209094943.14984-67-tiwai@suse.deSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 1075b321
...@@ -415,18 +415,6 @@ static int hiface_pcm_close(struct snd_pcm_substream *alsa_sub) ...@@ -415,18 +415,6 @@ static int hiface_pcm_close(struct snd_pcm_substream *alsa_sub)
return 0; return 0;
} }
static int hiface_pcm_hw_params(struct snd_pcm_substream *alsa_sub,
struct snd_pcm_hw_params *hw_params)
{
return snd_pcm_lib_malloc_pages(alsa_sub,
params_buffer_bytes(hw_params));
}
static int hiface_pcm_hw_free(struct snd_pcm_substream *alsa_sub)
{
return snd_pcm_lib_free_pages(alsa_sub);
}
static int hiface_pcm_prepare(struct snd_pcm_substream *alsa_sub) static int hiface_pcm_prepare(struct snd_pcm_substream *alsa_sub)
{ {
struct pcm_runtime *rt = snd_pcm_substream_chip(alsa_sub); struct pcm_runtime *rt = snd_pcm_substream_chip(alsa_sub);
...@@ -513,8 +501,6 @@ static const struct snd_pcm_ops pcm_ops = { ...@@ -513,8 +501,6 @@ static const struct snd_pcm_ops pcm_ops = {
.open = hiface_pcm_open, .open = hiface_pcm_open,
.close = hiface_pcm_close, .close = hiface_pcm_close,
.ioctl = snd_pcm_lib_ioctl, .ioctl = snd_pcm_lib_ioctl,
.hw_params = hiface_pcm_hw_params,
.hw_free = hiface_pcm_hw_free,
.prepare = hiface_pcm_prepare, .prepare = hiface_pcm_prepare,
.trigger = hiface_pcm_trigger, .trigger = hiface_pcm_trigger,
.pointer = hiface_pcm_pointer, .pointer = hiface_pcm_pointer,
...@@ -613,7 +599,7 @@ int hiface_pcm_init(struct hiface_chip *chip, u8 extra_freq) ...@@ -613,7 +599,7 @@ int hiface_pcm_init(struct hiface_chip *chip, u8 extra_freq)
strlcpy(pcm->name, "USB-SPDIF Audio", sizeof(pcm->name)); strlcpy(pcm->name, "USB-SPDIF Audio", sizeof(pcm->name));
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &pcm_ops); snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &pcm_ops);
snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_VMALLOC, snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_VMALLOC,
NULL, 0, 0); NULL, 0, 0);
rt->instance = pcm; rt->instance = pcm;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment