Commit d64906b3 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Alexandre Belloni

rtc: brcmstb-waketimer: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230304133028.2135435-8-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 06e5e4a5
...@@ -336,14 +336,12 @@ static int brcmstb_waketmr_probe(struct platform_device *pdev) ...@@ -336,14 +336,12 @@ static int brcmstb_waketmr_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int brcmstb_waketmr_remove(struct platform_device *pdev) static void brcmstb_waketmr_remove(struct platform_device *pdev)
{ {
struct brcmstb_waketmr *timer = dev_get_drvdata(&pdev->dev); struct brcmstb_waketmr *timer = dev_get_drvdata(&pdev->dev);
unregister_reboot_notifier(&timer->reboot_notifier); unregister_reboot_notifier(&timer->reboot_notifier);
clk_disable_unprepare(timer->clk); clk_disable_unprepare(timer->clk);
return 0;
} }
#ifdef CONFIG_PM_SLEEP #ifdef CONFIG_PM_SLEEP
...@@ -382,7 +380,7 @@ static const __maybe_unused struct of_device_id brcmstb_waketmr_of_match[] = { ...@@ -382,7 +380,7 @@ static const __maybe_unused struct of_device_id brcmstb_waketmr_of_match[] = {
static struct platform_driver brcmstb_waketmr_driver = { static struct platform_driver brcmstb_waketmr_driver = {
.probe = brcmstb_waketmr_probe, .probe = brcmstb_waketmr_probe,
.remove = brcmstb_waketmr_remove, .remove_new = brcmstb_waketmr_remove,
.driver = { .driver = {
.name = "brcmstb-waketimer", .name = "brcmstb-waketimer",
.pm = &brcmstb_waketmr_pm_ops, .pm = &brcmstb_waketmr_pm_ops,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment