Commit d74c62f4 authored by Alexander Viro's avatar Alexander Viro Committed by Linus Torvalds

[PATCH] appletalk SIOCADDRT fix

blind dereferencing of userland pointer in appletalk SIOCADDRT handling.
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent e7adc681
...@@ -908,12 +908,12 @@ static int atrtr_ioctl(unsigned int cmd, void __user *arg) ...@@ -908,12 +908,12 @@ static int atrtr_ioctl(unsigned int cmd, void __user *arg)
case SIOCADDRT: { case SIOCADDRT: {
struct net_device *dev = NULL; struct net_device *dev = NULL;
/*
* FIXME: the name of the device is still in user
* space, isn't it?
*/
if (rt.rt_dev) { if (rt.rt_dev) {
dev = __dev_get_by_name(rt.rt_dev); char name[IFNAMSIZ];
if (copy_from_user(name, rt.rt_dev, IFNAMSIZ-1))
return -EFAULT;
name[IFNAMSIZ-1] = '\0';
dev = __dev_get_by_name(name);
if (!dev) if (!dev)
return -ENODEV; return -ENODEV;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment