Commit da119a07 authored by Dario Binacchi's avatar Dario Binacchi Committed by Helge Deller

fbdev: imxfb: replace some magic numbers with constants

The patch gets rid of magic numbers replacing them with appropriate
macros.
Signed-off-by: default avatarDario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent b0e05872
...@@ -89,6 +89,7 @@ struct imx_fb_videomode { ...@@ -89,6 +89,7 @@ struct imx_fb_videomode {
#define PCR_BPIX_12 4 #define PCR_BPIX_12 4
#define PCR_BPIX_16 5 #define PCR_BPIX_16 5
#define PCR_BPIX_18 6 #define PCR_BPIX_18 6
#define PCR_PCD_MASK GENMASK(5, 0)
#define LCDC_HCR 0x1C #define LCDC_HCR 0x1C
#define HCR_H_WIDTH_MASK GENMASK(31, 26) #define HCR_H_WIDTH_MASK GENMASK(31, 26)
...@@ -414,8 +415,8 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) ...@@ -414,8 +415,8 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
pcr = (unsigned int)tmp; pcr = (unsigned int)tmp;
if (--pcr > 0x3F) { if (--pcr > PCR_PCD_MASK) {
pcr = 0x3F; pcr = PCR_PCD_MASK;
printk(KERN_WARNING "Must limit pixel clock to %luHz\n", printk(KERN_WARNING "Must limit pixel clock to %luHz\n",
lcd_clk / pcr); lcd_clk / pcr);
} }
...@@ -444,7 +445,7 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) ...@@ -444,7 +445,7 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
} }
/* add sync polarities */ /* add sync polarities */
pcr |= imxfb_mode->pcr & ~(0x3f | (7 << 25)); pcr |= imxfb_mode->pcr & ~(PCR_PCD_MASK | PCR_BPIX_MASK);
fbi->pcr = pcr; fbi->pcr = pcr;
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment