Commit dab8dfff authored by Miaohe Lin's avatar Miaohe Lin Committed by akpm

mm/swap: remove unneeded p != NULL check in __swap_duplicate

If p is NULL, __swap_duplicate will already return -EINVAL.  So if we
reach here, p must be non-NULL.

Link: https://lkml.kernel.org/r/20220509131416.17553-8-linmiaohe@huawei.comSigned-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
Reviewed-by: default avatarOscar Salvador <osalvador@suse.de>
Cc: Alistair Popple <apopple@nvidia.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Naoya Horiguchi <naoya.horiguchi@nec.com>
Cc: NeilBrown <neilb@suse.de>
Cc: Peter Xu <peterx@redhat.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent f19c2568
...@@ -3333,7 +3333,6 @@ static int __swap_duplicate(swp_entry_t entry, unsigned char usage) ...@@ -3333,7 +3333,6 @@ static int __swap_duplicate(swp_entry_t entry, unsigned char usage)
unlock_out: unlock_out:
unlock_cluster_or_swap_info(p, ci); unlock_cluster_or_swap_info(p, ci);
if (p)
put_swap_device(p); put_swap_device(p);
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment