Commit db7ddeab authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Torvalds

lib/test_kmod.c: potential double free in error handling

There is a copy and paste bug so we set "config->test_driver" to NULL
twice instead of setting "config->test_fs".  Smatch complains that it
leads to a double free:

  lib/test_kmod.c:840 __kmod_config_init() warn: 'config->test_fs' double freed

Link: http://lkml.kernel.org/r/20190121140011.GA14283@kadam
Fixes: d9c6a72d ("kmod: add test driver to stress test the module loader")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent cefc7ef3
...@@ -632,7 +632,7 @@ static void __kmod_config_free(struct test_config *config) ...@@ -632,7 +632,7 @@ static void __kmod_config_free(struct test_config *config)
config->test_driver = NULL; config->test_driver = NULL;
kfree_const(config->test_fs); kfree_const(config->test_fs);
config->test_driver = NULL; config->test_fs = NULL;
} }
static void kmod_config_free(struct kmod_test_device *test_dev) static void kmod_config_free(struct kmod_test_device *test_dev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment