Commit dc4547fb authored by Xuan Zhuo's avatar Xuan Zhuo Committed by Jakub Kicinski

Revert "virtio_net: rx remove premapped failover code"

This reverts commit defd28aa.

Recover the code to disable premapped mode.
Signed-off-by: default avatarXuan Zhuo <xuanzhuo@linux.alibaba.com>
Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Tested-by: default avatarTakero Funaki <flintglass@gmail.com>
Link: https://patch.msgid.link/20240906123137.108741-2-xuanzhuo@linux.alibaba.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fef2843b
...@@ -356,6 +356,9 @@ struct receive_queue { ...@@ -356,6 +356,9 @@ struct receive_queue {
struct xdp_rxq_info xsk_rxq_info; struct xdp_rxq_info xsk_rxq_info;
struct xdp_buff **xsk_buffs; struct xdp_buff **xsk_buffs;
/* Do dma by self */
bool do_dma;
}; };
/* This structure can contain rss message with maximum settings for indirection table and keysize /* This structure can contain rss message with maximum settings for indirection table and keysize
...@@ -885,7 +888,7 @@ static void *virtnet_rq_get_buf(struct receive_queue *rq, u32 *len, void **ctx) ...@@ -885,7 +888,7 @@ static void *virtnet_rq_get_buf(struct receive_queue *rq, u32 *len, void **ctx)
void *buf; void *buf;
buf = virtqueue_get_buf_ctx(rq->vq, len, ctx); buf = virtqueue_get_buf_ctx(rq->vq, len, ctx);
if (buf) if (buf && rq->do_dma)
virtnet_rq_unmap(rq, buf, *len); virtnet_rq_unmap(rq, buf, *len);
return buf; return buf;
...@@ -898,6 +901,11 @@ static void virtnet_rq_init_one_sg(struct receive_queue *rq, void *buf, u32 len) ...@@ -898,6 +901,11 @@ static void virtnet_rq_init_one_sg(struct receive_queue *rq, void *buf, u32 len)
u32 offset; u32 offset;
void *head; void *head;
if (!rq->do_dma) {
sg_init_one(rq->sg, buf, len);
return;
}
head = page_address(rq->alloc_frag.page); head = page_address(rq->alloc_frag.page);
offset = buf - head; offset = buf - head;
...@@ -923,6 +931,7 @@ static void *virtnet_rq_alloc(struct receive_queue *rq, u32 size, gfp_t gfp) ...@@ -923,6 +931,7 @@ static void *virtnet_rq_alloc(struct receive_queue *rq, u32 size, gfp_t gfp)
head = page_address(alloc_frag->page); head = page_address(alloc_frag->page);
if (rq->do_dma) {
dma = head; dma = head;
/* new pages */ /* new pages */
...@@ -958,6 +967,7 @@ static void *virtnet_rq_alloc(struct receive_queue *rq, u32 size, gfp_t gfp) ...@@ -958,6 +967,7 @@ static void *virtnet_rq_alloc(struct receive_queue *rq, u32 size, gfp_t gfp)
} }
++dma->ref; ++dma->ref;
}
buf = head + alloc_frag->offset; buf = head + alloc_frag->offset;
...@@ -975,9 +985,12 @@ static void virtnet_rq_set_premapped(struct virtnet_info *vi) ...@@ -975,9 +985,12 @@ static void virtnet_rq_set_premapped(struct virtnet_info *vi)
if (!vi->mergeable_rx_bufs && vi->big_packets) if (!vi->mergeable_rx_bufs && vi->big_packets)
return; return;
for (i = 0; i < vi->max_queue_pairs; i++) for (i = 0; i < vi->max_queue_pairs; i++) {
/* error should never happen */ if (virtqueue_set_dma_premapped(vi->rq[i].vq))
BUG_ON(virtqueue_set_dma_premapped(vi->rq[i].vq)); continue;
vi->rq[i].do_dma = true;
}
} }
static void virtnet_rq_unmap_free_buf(struct virtqueue *vq, void *buf) static void virtnet_rq_unmap_free_buf(struct virtqueue *vq, void *buf)
...@@ -2430,6 +2443,7 @@ static int add_recvbuf_small(struct virtnet_info *vi, struct receive_queue *rq, ...@@ -2430,6 +2443,7 @@ static int add_recvbuf_small(struct virtnet_info *vi, struct receive_queue *rq,
err = virtqueue_add_inbuf_ctx(rq->vq, rq->sg, 1, buf, ctx, gfp); err = virtqueue_add_inbuf_ctx(rq->vq, rq->sg, 1, buf, ctx, gfp);
if (err < 0) { if (err < 0) {
if (rq->do_dma)
virtnet_rq_unmap(rq, buf, 0); virtnet_rq_unmap(rq, buf, 0);
put_page(virt_to_head_page(buf)); put_page(virt_to_head_page(buf));
} }
...@@ -2544,6 +2558,7 @@ static int add_recvbuf_mergeable(struct virtnet_info *vi, ...@@ -2544,6 +2558,7 @@ static int add_recvbuf_mergeable(struct virtnet_info *vi,
ctx = mergeable_len_to_ctx(len + room, headroom); ctx = mergeable_len_to_ctx(len + room, headroom);
err = virtqueue_add_inbuf_ctx(rq->vq, rq->sg, 1, buf, ctx, gfp); err = virtqueue_add_inbuf_ctx(rq->vq, rq->sg, 1, buf, ctx, gfp);
if (err < 0) { if (err < 0) {
if (rq->do_dma)
virtnet_rq_unmap(rq, buf, 0); virtnet_rq_unmap(rq, buf, 0);
put_page(virt_to_head_page(buf)); put_page(virt_to_head_page(buf));
} }
...@@ -5892,7 +5907,7 @@ static void free_receive_page_frags(struct virtnet_info *vi) ...@@ -5892,7 +5907,7 @@ static void free_receive_page_frags(struct virtnet_info *vi)
int i; int i;
for (i = 0; i < vi->max_queue_pairs; i++) for (i = 0; i < vi->max_queue_pairs; i++)
if (vi->rq[i].alloc_frag.page) { if (vi->rq[i].alloc_frag.page) {
if (vi->rq[i].last_dma) if (vi->rq[i].do_dma && vi->rq[i].last_dma)
virtnet_rq_unmap(&vi->rq[i], vi->rq[i].last_dma, 0); virtnet_rq_unmap(&vi->rq[i], vi->rq[i].last_dma, 0);
put_page(vi->rq[i].alloc_frag.page); put_page(vi->rq[i].alloc_frag.page);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment