Commit de6862d1 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Vinod Koul

phy: qualcomm: phy-qcom-ipq806x-sata: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-15-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent e5ce6d9d
...@@ -170,13 +170,11 @@ static int qcom_ipq806x_sata_phy_probe(struct platform_device *pdev) ...@@ -170,13 +170,11 @@ static int qcom_ipq806x_sata_phy_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int qcom_ipq806x_sata_phy_remove(struct platform_device *pdev) static void qcom_ipq806x_sata_phy_remove(struct platform_device *pdev)
{ {
struct qcom_ipq806x_sata_phy *phy = platform_get_drvdata(pdev); struct qcom_ipq806x_sata_phy *phy = platform_get_drvdata(pdev);
clk_disable_unprepare(phy->cfg_clk); clk_disable_unprepare(phy->cfg_clk);
return 0;
} }
static const struct of_device_id qcom_ipq806x_sata_phy_of_match[] = { static const struct of_device_id qcom_ipq806x_sata_phy_of_match[] = {
...@@ -187,7 +185,7 @@ MODULE_DEVICE_TABLE(of, qcom_ipq806x_sata_phy_of_match); ...@@ -187,7 +185,7 @@ MODULE_DEVICE_TABLE(of, qcom_ipq806x_sata_phy_of_match);
static struct platform_driver qcom_ipq806x_sata_phy_driver = { static struct platform_driver qcom_ipq806x_sata_phy_driver = {
.probe = qcom_ipq806x_sata_phy_probe, .probe = qcom_ipq806x_sata_phy_probe,
.remove = qcom_ipq806x_sata_phy_remove, .remove_new = qcom_ipq806x_sata_phy_remove,
.driver = { .driver = {
.name = "qcom-ipq806x-sata-phy", .name = "qcom-ipq806x-sata-phy",
.of_match_table = qcom_ipq806x_sata_phy_of_match, .of_match_table = qcom_ipq806x_sata_phy_of_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment