Commit df3eb85b authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

media: iguanair: fix endpoint sanity check

[ Upstream commit 1b257870 ]

Make sure to use the current alternate setting, which need not be the
first one by index, when verifying the endpoint descriptors and
initialising the URBs.

Failing to do so could cause the driver to misbehave or trigger a WARN()
in usb_submit_urb() that kernels with panic_on_warn set would choke on.

Fixes: 26ff6313 ("[media] Add support for the IguanaWorks USB IR Transceiver")
Fixes: ab1cbdf1 ("media: iguanair: add sanity checks")
Cc: stable <stable@vger.kernel.org>     # 3.6
Cc: Oliver Neukum <oneukum@suse.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent bdfaaf35
...@@ -424,7 +424,7 @@ static int iguanair_probe(struct usb_interface *intf, ...@@ -424,7 +424,7 @@ static int iguanair_probe(struct usb_interface *intf,
int ret, pipein, pipeout; int ret, pipein, pipeout;
struct usb_host_interface *idesc; struct usb_host_interface *idesc;
idesc = intf->altsetting; idesc = intf->cur_altsetting;
if (idesc->desc.bNumEndpoints < 2) if (idesc->desc.bNumEndpoints < 2)
return -ENODEV; return -ENODEV;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment