Commit df71b091 authored by Richard Weinberger's avatar Richard Weinberger

ubifs: Fail commit if TNC is obviously inconsistent

A reference to LEB 0 or with length 0 in the TNC
is never correct and could be caused by a memory corruption.
Don't write such a bad index node to the MTD.
Instead fail the commit which will turn UBIFS into read-only mode.

This is less painful than having the bad reference on the MTD
from where UBFIS has no chance to recover.
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent 319c1042
...@@ -57,6 +57,8 @@ static int make_idx_node(struct ubifs_info *c, struct ubifs_idx_node *idx, ...@@ -57,6 +57,8 @@ static int make_idx_node(struct ubifs_info *c, struct ubifs_idx_node *idx,
ubifs_dump_znode(c, znode); ubifs_dump_znode(c, znode);
if (zbr->znode) if (zbr->znode)
ubifs_dump_znode(c, zbr->znode); ubifs_dump_znode(c, zbr->znode);
return -EINVAL;
} }
} }
ubifs_prepare_node(c, idx, len, 0); ubifs_prepare_node(c, idx, len, 0);
...@@ -859,6 +861,8 @@ static int write_index(struct ubifs_info *c) ...@@ -859,6 +861,8 @@ static int write_index(struct ubifs_info *c)
ubifs_dump_znode(c, znode); ubifs_dump_znode(c, znode);
if (zbr->znode) if (zbr->znode)
ubifs_dump_znode(c, zbr->znode); ubifs_dump_znode(c, zbr->znode);
return -EINVAL;
} }
} }
len = ubifs_idx_node_sz(c, znode->child_cnt); len = ubifs_idx_node_sz(c, znode->child_cnt);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment