Commit df7926ff authored by Tim Kryger's avatar Tim Kryger Committed by Mark Brown

regulator: core: Return error in get optional stub

Drivers that call regulator_get_optional are tolerant to the absence of
that regulator.  By modifying the value returned from the stub function
to match that seen when a regulator isn't present, callers can wrap the
regulator logic with an IS_ERR based conditional even if they happen to
call regulator_is_supported_voltage.  This improves efficiency as well
as eliminates the possibility for a very subtle bug.
Signed-off-by: default avatarTim Kryger <tim.kryger@linaro.org>
Reviewed-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent c9eaa447
...@@ -258,14 +258,14 @@ regulator_get_exclusive(struct device *dev, const char *id) ...@@ -258,14 +258,14 @@ regulator_get_exclusive(struct device *dev, const char *id)
static inline struct regulator *__must_check static inline struct regulator *__must_check
regulator_get_optional(struct device *dev, const char *id) regulator_get_optional(struct device *dev, const char *id)
{ {
return NULL; return ERR_PTR(-ENODEV);
} }
static inline struct regulator *__must_check static inline struct regulator *__must_check
devm_regulator_get_optional(struct device *dev, const char *id) devm_regulator_get_optional(struct device *dev, const char *id)
{ {
return NULL; return ERR_PTR(-ENODEV);
} }
static inline void regulator_put(struct regulator *regulator) static inline void regulator_put(struct regulator *regulator)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment