Commit e0240794 authored by Russell Currey's avatar Russell Currey Committed by Michael Ellerman

powerpc/secvar: Handle max object size in the consumer

Currently the max object size is handled in the core secvar code with an
entirely OPAL-specific implementation, so create a new max_size() op and
move the existing implementation into the powernv platform.  Should be
no functional change.
Signed-off-by: default avatarRussell Currey <ruscur@russell.cc>
Signed-off-by: default avatarAndrew Donnellan <ajd@linux.ibm.com>
Reviewed-by: default avatarStefan Berger <stefanb@linux.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20230210080401.345462-9-ajd@linux.ibm.com
parent ec2f40bd
...@@ -18,6 +18,7 @@ struct secvar_operations { ...@@ -18,6 +18,7 @@ struct secvar_operations {
int (*get_next)(const char *key, u64 *key_len, u64 keybufsize); int (*get_next)(const char *key, u64 *key_len, u64 keybufsize);
int (*set)(const char *key, u64 key_len, u8 *data, u64 data_size); int (*set)(const char *key, u64 key_len, u8 *data, u64 data_size);
ssize_t (*format)(char *buf, size_t bufsize); ssize_t (*format)(char *buf, size_t bufsize);
int (*max_size)(u64 *max_size);
}; };
#ifdef CONFIG_PPC_SECURE_BOOT #ifdef CONFIG_PPC_SECURE_BOOT
......
...@@ -132,27 +132,16 @@ static struct kobj_type secvar_ktype = { ...@@ -132,27 +132,16 @@ static struct kobj_type secvar_ktype = {
static int update_kobj_size(void) static int update_kobj_size(void)
{ {
struct device_node *node;
u64 varsize; u64 varsize;
int rc = 0; int rc = secvar_ops->max_size(&varsize);
node = of_find_compatible_node(NULL, NULL, "ibm,secvar-backend");
if (!of_device_is_available(node)) {
rc = -ENODEV;
goto out;
}
rc = of_property_read_u64(node, "max-var-size", &varsize);
if (rc) if (rc)
goto out; return rc;
data_attr.size = varsize; data_attr.size = varsize;
update_attr.size = varsize; update_attr.size = varsize;
out: return 0;
of_node_put(node);
return rc;
} }
static int secvar_sysfs_load(void) static int secvar_sysfs_load(void)
......
...@@ -122,11 +122,33 @@ static ssize_t opal_secvar_format(char *buf, size_t bufsize) ...@@ -122,11 +122,33 @@ static ssize_t opal_secvar_format(char *buf, size_t bufsize)
return rc; return rc;
} }
static int opal_secvar_max_size(u64 *max_size)
{
int rc;
struct device_node *node;
node = of_find_compatible_node(NULL, NULL, "ibm,secvar-backend");
if (!node)
return -ENODEV;
if (!of_device_is_available(node)) {
rc = -ENODEV;
goto out;
}
rc = of_property_read_u64(node, "max-var-size", max_size);
out:
of_node_put(node);
return rc;
}
static const struct secvar_operations opal_secvar_ops = { static const struct secvar_operations opal_secvar_ops = {
.get = opal_get_variable, .get = opal_get_variable,
.get_next = opal_get_next_variable, .get_next = opal_get_next_variable,
.set = opal_set_variable, .set = opal_set_variable,
.format = opal_secvar_format, .format = opal_secvar_format,
.max_size = opal_secvar_max_size,
}; };
static int opal_secvar_probe(struct platform_device *pdev) static int opal_secvar_probe(struct platform_device *pdev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment