Commit e0f49d27 authored by Markus Elfring's avatar Markus Elfring Committed by Theodore Ts'o

ext4: delete unnecessary checks before brelse()

The brelse() function tests whether its argument is NULL
and then returns immediately.
Thus remove the tests which are not needed around the shown calls.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Reviewed-by: default avatarRitesh Harjani <riteshh@linux.ibm.com>
Link: https://lore.kernel.org/r/0d713702-072f-a89c-20ec-ca70aa83a432@web.deSigned-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent e4d7f2d3
...@@ -693,11 +693,9 @@ void ext4_ext_drop_refs(struct ext4_ext_path *path) ...@@ -693,11 +693,9 @@ void ext4_ext_drop_refs(struct ext4_ext_path *path)
return; return;
depth = path->p_depth; depth = path->p_depth;
for (i = 0; i <= depth; i++, path++) { for (i = 0; i <= depth; i++, path++) {
if (path->p_bh) {
brelse(path->p_bh); brelse(path->p_bh);
path->p_bh = NULL; path->p_bh = NULL;
} }
}
} }
/* /*
......
...@@ -1356,7 +1356,6 @@ static int ext4_xattr_inode_write(handle_t *handle, struct inode *ea_inode, ...@@ -1356,7 +1356,6 @@ static int ext4_xattr_inode_write(handle_t *handle, struct inode *ea_inode,
block = 0; block = 0;
while (wsize < bufsize) { while (wsize < bufsize) {
if (bh != NULL)
brelse(bh); brelse(bh);
csize = (bufsize - wsize) > blocksize ? blocksize : csize = (bufsize - wsize) > blocksize ? blocksize :
bufsize - wsize; bufsize - wsize;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment