Commit e0f63b21 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen

scsi: libfc: Call scsi_done() directly

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-44-bvanassche@acm.orgSigned-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 98cc0e69
...@@ -1870,7 +1870,7 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd) ...@@ -1870,7 +1870,7 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd)
rval = fc_remote_port_chkready(rport); rval = fc_remote_port_chkready(rport);
if (rval) { if (rval) {
sc_cmd->result = rval; sc_cmd->result = rval;
sc_cmd->scsi_done(sc_cmd); scsi_done(sc_cmd);
return 0; return 0;
} }
...@@ -1880,7 +1880,7 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd) ...@@ -1880,7 +1880,7 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd)
* online * online
*/ */
sc_cmd->result = DID_IMM_RETRY << 16; sc_cmd->result = DID_IMM_RETRY << 16;
sc_cmd->scsi_done(sc_cmd); scsi_done(sc_cmd);
goto out; goto out;
} }
...@@ -2087,7 +2087,7 @@ static void fc_io_compl(struct fc_fcp_pkt *fsp) ...@@ -2087,7 +2087,7 @@ static void fc_io_compl(struct fc_fcp_pkt *fsp)
list_del(&fsp->list); list_del(&fsp->list);
sc_cmd->SCp.ptr = NULL; sc_cmd->SCp.ptr = NULL;
spin_unlock_irqrestore(&si->scsi_queue_lock, flags); spin_unlock_irqrestore(&si->scsi_queue_lock, flags);
sc_cmd->scsi_done(sc_cmd); scsi_done(sc_cmd);
/* release ref from initial allocation in queue command */ /* release ref from initial allocation in queue command */
fc_fcp_pkt_release(fsp); fc_fcp_pkt_release(fsp);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment