Commit e1e46479 authored by Xin Long's avatar Xin Long Committed by David S. Miller

sctp: not increase stream's incnt before sending addstrm_in request

Different from processing the addstrm_out request, The receiver handles
an addstrm_in request by sending back an addstrm_out request to the
sender who will increase its stream's in and incnt later.

Now stream->incnt has been increased since it sent out the addstrm_in
request in sctp_send_add_streams(), with the wrong stream->incnt will
even cause crash when copying stream info from the old stream's in to
the new one's in sctp_process_strreset_addstrm_out().

This patch is to fix it by simply removing the stream->incnt change
from sctp_send_add_streams().

Fixes: 242bd2d5 ("sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter")
Reported-by: default avatarJianwen Ji <jiji@redhat.com>
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 69fec325
...@@ -535,7 +535,6 @@ int sctp_send_add_streams(struct sctp_association *asoc, ...@@ -535,7 +535,6 @@ int sctp_send_add_streams(struct sctp_association *asoc,
goto out; goto out;
} }
stream->incnt = incnt;
stream->outcnt = outcnt; stream->outcnt = outcnt;
asoc->strreset_outstanding = !!out + !!in; asoc->strreset_outstanding = !!out + !!in;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment