Commit e5733321 authored by Vlad Yasevich's avatar Vlad Yasevich Committed by David S. Miller

macvtap: Ignore tap features when VNET_HDR is off

When the user turns off VNET_HDR support on the
macvtap device, there is no way to provide any
offload information to the user.  So, it's safer
to ignore offload setting then depend on the user
setting them correctly.
Signed-off-by: default avatarVlad Yasevich <vyasevic@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e558b018
...@@ -290,8 +290,10 @@ static int macvtap_forward(struct net_device *dev, struct sk_buff *skb) ...@@ -290,8 +290,10 @@ static int macvtap_forward(struct net_device *dev, struct sk_buff *skb)
skb->dev = dev; skb->dev = dev;
/* Apply the forward feature mask so that we perform segmentation /* Apply the forward feature mask so that we perform segmentation
* according to users wishes. * according to users wishes. This only works if VNET_HDR is
* enabled.
*/ */
if (q->flags & IFF_VNET_HDR)
features |= vlan->tap_features; features |= vlan->tap_features;
if (netif_needs_gso(skb, features)) { if (netif_needs_gso(skb, features)) {
struct sk_buff *segs = __skb_gso_segment(skb, features, false); struct sk_buff *segs = __skb_gso_segment(skb, features, false);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment