Commit e63f8f43 authored by Olof Johansson's avatar Olof Johansson Committed by Linus Torvalds

[PATCH] ppc64: no prefetch for NULL pointers

For prefetches of NULL (as when walking a short linked list), PPC64 will in
some cases take a performance hit.  The hardware needs to do the TLB walk,
and said walk will always miss, which means (up to) two L2 misses as
penalty.  This seems to hurt overall performance, so for NULL pointers skip
the prefetch alltogether.
Signed-off-by: default avatarOlof Johansson <olof@austin.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 89e09f5e
...@@ -642,11 +642,17 @@ static inline unsigned long __pack_fe01(unsigned int fpmode) ...@@ -642,11 +642,17 @@ static inline unsigned long __pack_fe01(unsigned int fpmode)
static inline void prefetch(const void *x) static inline void prefetch(const void *x)
{ {
if (unlikely(!x))
return;
__asm__ __volatile__ ("dcbt 0,%0" : : "r" (x)); __asm__ __volatile__ ("dcbt 0,%0" : : "r" (x));
} }
static inline void prefetchw(const void *x) static inline void prefetchw(const void *x)
{ {
if (unlikely(!x))
return;
__asm__ __volatile__ ("dcbtst 0,%0" : : "r" (x)); __asm__ __volatile__ ("dcbtst 0,%0" : : "r" (x));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment