Commit e7c8f507 authored by Theodore Ts'o's avatar Theodore Ts'o

ext3: Add replace-on-rename hueristics for data=writeback mode

In data=writeback mode, start an asynchronous flush when renaming a
file on top of an already-existing file.  This lowers the probability
of data loss in the case of applications that attempt to replace a
file via using rename().
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent f7ab34ea
...@@ -2265,7 +2265,7 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry, ...@@ -2265,7 +2265,7 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry,
struct inode * old_inode, * new_inode; struct inode * old_inode, * new_inode;
struct buffer_head * old_bh, * new_bh, * dir_bh; struct buffer_head * old_bh, * new_bh, * dir_bh;
struct ext3_dir_entry_2 * old_de, * new_de; struct ext3_dir_entry_2 * old_de, * new_de;
int retval; int retval, flush_file = 0;
old_bh = new_bh = dir_bh = NULL; old_bh = new_bh = dir_bh = NULL;
...@@ -2401,6 +2401,8 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry, ...@@ -2401,6 +2401,8 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry,
ext3_mark_inode_dirty(handle, new_inode); ext3_mark_inode_dirty(handle, new_inode);
if (!new_inode->i_nlink) if (!new_inode->i_nlink)
ext3_orphan_add(handle, new_inode); ext3_orphan_add(handle, new_inode);
if (ext3_should_writeback_data(new_inode))
flush_file = 1;
} }
retval = 0; retval = 0;
...@@ -2409,6 +2411,8 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry, ...@@ -2409,6 +2411,8 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry,
brelse (old_bh); brelse (old_bh);
brelse (new_bh); brelse (new_bh);
ext3_journal_stop(handle); ext3_journal_stop(handle);
if (retval == 0 && flush_file)
filemap_flush(old_inode->i_mapping);
return retval; return retval;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment