Commit e8c3753c authored by Dave Chinner's avatar Dave Chinner Committed by Alex Elder

xfs: don't warn about page discards on shutdown

If we are doing a forced shutdown, we can get lots of noise about
delalloc pages being discarded. This is happens by design during a
forced shutdown, so don't spam the logs with these messages.
Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
parent 8a262e57
...@@ -932,6 +932,9 @@ xfs_aops_discard_page( ...@@ -932,6 +932,9 @@ xfs_aops_discard_page(
if (!xfs_is_delayed_page(page, IOMAP_DELAY)) if (!xfs_is_delayed_page(page, IOMAP_DELAY))
goto out_invalidate; goto out_invalidate;
if (XFS_FORCED_SHUTDOWN(ip->i_mount))
goto out_invalidate;
xfs_fs_cmn_err(CE_ALERT, ip->i_mount, xfs_fs_cmn_err(CE_ALERT, ip->i_mount,
"page discard on page %p, inode 0x%llx, offset %llu.", "page discard on page %p, inode 0x%llx, offset %llu.",
page, ip->i_ino, offset); page, ip->i_ino, offset);
...@@ -964,8 +967,10 @@ xfs_aops_discard_page( ...@@ -964,8 +967,10 @@ xfs_aops_discard_page(
if (error) { if (error) {
/* something screwed, just bail */ /* something screwed, just bail */
if (!XFS_FORCED_SHUTDOWN(ip->i_mount)) {
xfs_fs_cmn_err(CE_ALERT, ip->i_mount, xfs_fs_cmn_err(CE_ALERT, ip->i_mount,
"page discard failed delalloc mapping lookup."); "page discard failed delalloc mapping lookup.");
}
break; break;
} }
if (!nimaps) { if (!nimaps) {
...@@ -991,8 +996,10 @@ xfs_aops_discard_page( ...@@ -991,8 +996,10 @@ xfs_aops_discard_page(
ASSERT(!flist.xbf_count && !flist.xbf_first); ASSERT(!flist.xbf_count && !flist.xbf_first);
if (error) { if (error) {
/* something screwed, just bail */ /* something screwed, just bail */
if (!XFS_FORCED_SHUTDOWN(ip->i_mount)) {
xfs_fs_cmn_err(CE_ALERT, ip->i_mount, xfs_fs_cmn_err(CE_ALERT, ip->i_mount,
"page discard unable to remove delalloc mapping."); "page discard unable to remove delalloc mapping.");
}
break; break;
} }
next_buffer: next_buffer:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment