Commit e9548fdf authored by Shay Agroskin's avatar Shay Agroskin Committed by Jakub Kicinski

net: ena: store values in their appropriate variables types

This patch changes some of the variables types to match the values they
hold. These wrong types fail some of our static checkers that search for
accidental conversions in our driver.
Signed-off-by: default avatarIdo Segev <idose@amazon.com>
Signed-off-by: default avatarIgor Chauskin <igorch@amazon.com>
Signed-off-by: default avatarShay Agroskin <shayagr@amazon.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent da580ca8
...@@ -1360,16 +1360,15 @@ int ena_com_execute_admin_command(struct ena_com_admin_queue *admin_queue, ...@@ -1360,16 +1360,15 @@ int ena_com_execute_admin_command(struct ena_com_admin_queue *admin_queue,
comp_ctx = ena_com_submit_admin_cmd(admin_queue, cmd, cmd_size, comp_ctx = ena_com_submit_admin_cmd(admin_queue, cmd, cmd_size,
comp, comp_size); comp, comp_size);
if (IS_ERR(comp_ctx)) { if (IS_ERR(comp_ctx)) {
if (comp_ctx == ERR_PTR(-ENODEV)) ret = PTR_ERR(comp_ctx);
if (ret == -ENODEV)
netdev_dbg(admin_queue->ena_dev->net_device, netdev_dbg(admin_queue->ena_dev->net_device,
"Failed to submit command [%ld]\n", "Failed to submit command [%d]\n", ret);
PTR_ERR(comp_ctx));
else else
netdev_err(admin_queue->ena_dev->net_device, netdev_err(admin_queue->ena_dev->net_device,
"Failed to submit command [%ld]\n", "Failed to submit command [%d]\n", ret);
PTR_ERR(comp_ctx));
return PTR_ERR(comp_ctx); return ret;
} }
ret = ena_com_wait_and_process_admin_cq(comp_ctx, admin_queue); ret = ena_com_wait_and_process_admin_cq(comp_ctx, admin_queue);
...@@ -1595,7 +1594,7 @@ int ena_com_set_aenq_config(struct ena_com_dev *ena_dev, u32 groups_flag) ...@@ -1595,7 +1594,7 @@ int ena_com_set_aenq_config(struct ena_com_dev *ena_dev, u32 groups_flag)
int ena_com_get_dma_width(struct ena_com_dev *ena_dev) int ena_com_get_dma_width(struct ena_com_dev *ena_dev)
{ {
u32 caps = ena_com_reg_bar_read32(ena_dev, ENA_REGS_CAPS_OFF); u32 caps = ena_com_reg_bar_read32(ena_dev, ENA_REGS_CAPS_OFF);
int width; u32 width;
if (unlikely(caps == ENA_MMIO_READ_TIMEOUT)) { if (unlikely(caps == ENA_MMIO_READ_TIMEOUT)) {
netdev_err(ena_dev->net_device, "Reg read timeout occurred\n"); netdev_err(ena_dev->net_device, "Reg read timeout occurred\n");
...@@ -2247,7 +2246,7 @@ int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev, ...@@ -2247,7 +2246,7 @@ int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev,
return ret; return ret;
} }
int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, int mtu) int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, u32 mtu)
{ {
struct ena_com_admin_queue *admin_queue; struct ena_com_admin_queue *admin_queue;
struct ena_admin_set_feat_cmd cmd; struct ena_admin_set_feat_cmd cmd;
......
...@@ -605,7 +605,7 @@ int ena_com_get_eni_stats(struct ena_com_dev *ena_dev, ...@@ -605,7 +605,7 @@ int ena_com_get_eni_stats(struct ena_com_dev *ena_dev,
* *
* @return: 0 on Success and negative value otherwise. * @return: 0 on Success and negative value otherwise.
*/ */
int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, int mtu); int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, u32 mtu);
/* ena_com_get_offload_settings - Retrieve the device offloads capabilities /* ena_com_get_offload_settings - Retrieve the device offloads capabilities
* @ena_dev: ENA communication layer struct * @ena_dev: ENA communication layer struct
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment