Commit e98062ed authored by Sedat Dilek's avatar Sedat Dilek Committed by Matthew Garrett

platform/x86: Kconfig: Replace select by depends on ACPI_WMI

With 'make oldnoconfig' I see these warnings in linux-next (next-20101208):

drivers/platform/x86/Kconfig:422:error: recursive dependency detected!
drivers/platform/x86/Kconfig:422:       symbol EEEPC_WMI depends on ACPI_WMI
drivers/platform/x86/Kconfig:438:       symbol ACPI_WMI is selected by ACER_WMI
drivers/platform/x86/Kconfig:18:        symbol ACER_WMI depends on LEDS_CLASS
drivers/leds/Kconfig:10:        symbol LEDS_CLASS is selected by EEEPC_WMI

This patch replaces all "select on ACPI_WMI" by "depends on ACPI_WMI".

Quote from David Woodhouse:
"A better policy is: "NEVER USE SELECT"."
Reported-and-tested-by: default avatarSedat Dilek <sedat.dilek@gmail.com>
Signed-off-by: default avatarSedat Dilek <sedat.dilek@gmail.com>
Acked-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
parent c1f73658
...@@ -23,7 +23,7 @@ config ACER_WMI ...@@ -23,7 +23,7 @@ config ACER_WMI
depends on BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_CLASS_DEVICE
depends on SERIO_I8042 depends on SERIO_I8042
depends on RFKILL || RFKILL = n depends on RFKILL || RFKILL = n
select ACPI_WMI depends on ACPI_WMI
---help--- ---help---
This is a driver for newer Acer (and Wistron) laptops. It adds This is a driver for newer Acer (and Wistron) laptops. It adds
wireless radio and bluetooth control, and on some laptops, wireless radio and bluetooth control, and on some laptops,
...@@ -131,7 +131,7 @@ config TC1100_WMI ...@@ -131,7 +131,7 @@ config TC1100_WMI
depends on !X86_64 depends on !X86_64
depends on EXPERIMENTAL depends on EXPERIMENTAL
depends on ACPI depends on ACPI
select ACPI_WMI depends on ACPI_WMI
---help--- ---help---
This is a driver for the WMI extensions (wireless and bluetooth power This is a driver for the WMI extensions (wireless and bluetooth power
control) of the HP Compaq TC1100 tablet. control) of the HP Compaq TC1100 tablet.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment