Commit ebecc6c4 authored by Kevin Wang's avatar Kevin Wang Committed by Alex Deucher

drm/amd/powerplay: fix variable type errors in smu_v11_0_setup_pptable

fix size type errors, from uint32_t to uint16_t.
it will cause only initializes the highest 16 bits in
smu_get_atom_data_table function.

bug report:
This fixes the following static checker warning.
        drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:390 smu_v11_0_setup_pptable()
        warn: passing casted pointer '&size' to 'smu_get_atom_data_table()' 32 vs 16.
Signed-off-by: default avatarKevin Wang <kevin1.wang@amd.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarEvan Quan <evan.quan@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 97442140
...@@ -360,6 +360,7 @@ static int smu_v11_0_setup_pptable(struct smu_context *smu) ...@@ -360,6 +360,7 @@ static int smu_v11_0_setup_pptable(struct smu_context *smu)
const struct smc_firmware_header_v1_0 *hdr; const struct smc_firmware_header_v1_0 *hdr;
int ret, index; int ret, index;
uint32_t size; uint32_t size;
uint16_t atom_table_size;
uint8_t frev, crev; uint8_t frev, crev;
void *table; void *table;
uint16_t version_major, version_minor; uint16_t version_major, version_minor;
...@@ -387,10 +388,11 @@ static int smu_v11_0_setup_pptable(struct smu_context *smu) ...@@ -387,10 +388,11 @@ static int smu_v11_0_setup_pptable(struct smu_context *smu)
index = get_index_into_master_table(atom_master_list_of_data_tables_v2_1, index = get_index_into_master_table(atom_master_list_of_data_tables_v2_1,
powerplayinfo); powerplayinfo);
ret = smu_get_atom_data_table(smu, index, (uint16_t *)&size, &frev, &crev, ret = smu_get_atom_data_table(smu, index, &atom_table_size, &frev, &crev,
(uint8_t **)&table); (uint8_t **)&table);
if (ret) if (ret)
return ret; return ret;
size = atom_table_size;
} }
if (!smu->smu_table.power_play_table) if (!smu->smu_table.power_play_table)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment