Commit ee430f16 authored by Thomas Abraham's avatar Thomas Abraham Committed by Kukjin Kim

serial: samsung: Fix unintended usage of uart port 0 as console

In s3c24xx_serial_console_setup function, if the uart port that is
being setup as a console has not been initialized, an error can be
returned instead of using uart port 0 as the default console port.
The uart port that was intended to be used as a console could be
initialized at a later point during boot and then registered as a
console. This will avoid using uart port 0 as a unintended console
port.
Signed-off-by: default avatarThomas Abraham <thomas.ab@samsung.com>
Signed-off-by: default avatarKukjin Kim <kgene.kim@samsung.com>
parent 2c53b436
...@@ -1416,10 +1416,8 @@ s3c24xx_serial_console_setup(struct console *co, char *options) ...@@ -1416,10 +1416,8 @@ s3c24xx_serial_console_setup(struct console *co, char *options)
/* is the port configured? */ /* is the port configured? */
if (port->mapbase == 0x0) { if (port->mapbase == 0x0)
co->index = 0; return -ENODEV;
port = &s3c24xx_serial_ports[co->index].port;
}
cons_uart = port; cons_uart = port;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment