Commit ee522bcf authored by Yang Yingliang's avatar Yang Yingliang Committed by Pavel Machek

leds: tlc591xx: fix return value check in tlc591xx_probe()

After device_get_match_data(), tlc591xx is not checked, add
check for it and also check np after dev_of_node.
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
parent 6efb943b
...@@ -148,16 +148,20 @@ static int ...@@ -148,16 +148,20 @@ static int
tlc591xx_probe(struct i2c_client *client, tlc591xx_probe(struct i2c_client *client,
const struct i2c_device_id *id) const struct i2c_device_id *id)
{ {
struct device_node *np = dev_of_node(&client->dev), *child; struct device_node *np, *child;
struct device *dev = &client->dev; struct device *dev = &client->dev;
const struct tlc591xx *tlc591xx; const struct tlc591xx *tlc591xx;
struct tlc591xx_priv *priv; struct tlc591xx_priv *priv;
int err, count, reg; int err, count, reg;
tlc591xx = device_get_match_data(dev); np = dev_of_node(dev);
if (!np) if (!np)
return -ENODEV; return -ENODEV;
tlc591xx = device_get_match_data(dev);
if (!tlc591xx)
return -ENODEV;
count = of_get_available_child_count(np); count = of_get_available_child_count(np);
if (!count || count > tlc591xx->max_leds) if (!count || count > tlc591xx->max_leds)
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment