Commit eeac8cda authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen

scsi: cxlflash: return -EFAULT if copy_from_user() fails

The copy_from/to_user() functions return the number of bytes remaining
to be copied but we had intended to return -EFAULT here.

Fixes: bc88ac47 ("scsi: cxlflash: Support AFU debug")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarMatthew R. Ochs <mrochs@linux.vnet.ibm.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c57ec8fb
...@@ -3401,11 +3401,12 @@ static int cxlflash_afu_debug(struct cxlflash_cfg *cfg, ...@@ -3401,11 +3401,12 @@ static int cxlflash_afu_debug(struct cxlflash_cfg *cfg,
if (is_write) { if (is_write) {
req_flags |= SISL_REQ_FLAGS_HOST_WRITE; req_flags |= SISL_REQ_FLAGS_HOST_WRITE;
rc = copy_from_user(kbuf, ubuf, ulen); if (copy_from_user(kbuf, ubuf, ulen)) {
if (unlikely(rc)) rc = -EFAULT;
goto out; goto out;
} }
} }
}
memset(&rcb, 0, sizeof(rcb)); memset(&rcb, 0, sizeof(rcb));
memset(&asa, 0, sizeof(asa)); memset(&asa, 0, sizeof(asa));
...@@ -3431,8 +3432,10 @@ static int cxlflash_afu_debug(struct cxlflash_cfg *cfg, ...@@ -3431,8 +3432,10 @@ static int cxlflash_afu_debug(struct cxlflash_cfg *cfg,
goto out; goto out;
} }
if (ulen && !is_write) if (ulen && !is_write) {
rc = copy_to_user(ubuf, kbuf, ulen); if (copy_to_user(ubuf, kbuf, ulen))
rc = -EFAULT;
}
out: out:
kfree(buf); kfree(buf);
dev_dbg(dev, "%s: returning rc=%d\n", __func__, rc); dev_dbg(dev, "%s: returning rc=%d\n", __func__, rc);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment