Commit f0f1fa04 authored by Swapnil Jakhade's avatar Swapnil Jakhade Committed by Vinod Koul

phy: cadence-torrent: Update PHY reset for multilink configuration

For multilink configuration, deassert PHY and link reset after PHY
registers are configured in probe and only check link status in
power_on callback.
Signed-off-by: default avatarSwapnil Jakhade <sjakhade@cadence.com>
Link: https://lore.kernel.org/r/1600327846-9733-7-git-send-email-sjakhade@cadence.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 6bcf3cb3
...@@ -1603,13 +1603,15 @@ static int cdns_torrent_phy_on(struct phy *phy) ...@@ -1603,13 +1603,15 @@ static int cdns_torrent_phy_on(struct phy *phy)
u32 read_val; u32 read_val;
int ret; int ret;
if (cdns_phy->nsubnodes == 1) {
/* Take the PHY lane group out of reset */
reset_control_deassert(inst->lnk_rst);
/* Take the PHY out of reset */ /* Take the PHY out of reset */
ret = reset_control_deassert(cdns_phy->phy_rst); ret = reset_control_deassert(cdns_phy->phy_rst);
if (ret) if (ret)
return ret; return ret;
}
/* Take the PHY lane group out of reset */
reset_control_deassert(inst->lnk_rst);
/* /*
* Wait for cmn_ready assertion * Wait for cmn_ready assertion
...@@ -1623,6 +1625,8 @@ static int cdns_torrent_phy_on(struct phy *phy) ...@@ -1623,6 +1625,8 @@ static int cdns_torrent_phy_on(struct phy *phy)
return ret; return ret;
} }
mdelay(10);
return 0; return 0;
} }
...@@ -1632,6 +1636,9 @@ static int cdns_torrent_phy_off(struct phy *phy) ...@@ -1632,6 +1636,9 @@ static int cdns_torrent_phy_off(struct phy *phy)
struct cdns_torrent_phy *cdns_phy = dev_get_drvdata(phy->dev.parent); struct cdns_torrent_phy *cdns_phy = dev_get_drvdata(phy->dev.parent);
int ret; int ret;
if (cdns_phy->nsubnodes != 1)
return 0;
ret = reset_control_assert(cdns_phy->phy_rst); ret = reset_control_assert(cdns_phy->phy_rst);
if (ret) if (ret)
return ret; return ret;
...@@ -1886,7 +1893,7 @@ int cdns_torrent_phy_configure_multilink(struct cdns_torrent_phy *cdns_phy) ...@@ -1886,7 +1893,7 @@ int cdns_torrent_phy_configure_multilink(struct cdns_torrent_phy *cdns_phy)
struct cdns_torrent_vals *cmn_vals, *tx_ln_vals, *rx_ln_vals; struct cdns_torrent_vals *cmn_vals, *tx_ln_vals, *rx_ln_vals;
struct cdns_torrent_vals *link_cmn_vals, *xcvr_diag_vals; struct cdns_torrent_vals *link_cmn_vals, *xcvr_diag_vals;
enum cdns_torrent_phy_type phy_t1, phy_t2, tmp_phy_type; enum cdns_torrent_phy_type phy_t1, phy_t2, tmp_phy_type;
int i, j, node, mlane, num_lanes; int i, j, node, mlane, num_lanes, ret;
struct cdns_reg_pairs *reg_pairs; struct cdns_reg_pairs *reg_pairs;
enum cdns_torrent_ssc_mode ssc; enum cdns_torrent_ssc_mode ssc;
struct regmap *regmap; struct regmap *regmap;
...@@ -1989,8 +1996,15 @@ int cdns_torrent_phy_configure_multilink(struct cdns_torrent_phy *cdns_phy) ...@@ -1989,8 +1996,15 @@ int cdns_torrent_phy_configure_multilink(struct cdns_torrent_phy *cdns_phy)
reg_pairs[j].val); reg_pairs[j].val);
} }
} }
reset_control_deassert(cdns_phy->phys[node].lnk_rst);
} }
/* Take the PHY out of reset */
ret = reset_control_deassert(cdns_phy->phy_rst);
if (ret)
return ret;
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment