Commit f2980103 authored by Kai-Heng Feng's avatar Kai-Heng Feng Committed by Jeff Kirsher

e1000e: Disable TSO for buffer overrun workaround

Commit b10effb9 ("e1000e: fix buffer overrun while the I219 is
processing DMA transactions") imposes roughly 30% performance penalty.

The commit log states that "Disabling TSO eliminates performance loss
for TCP traffic without a noticeable impact on CPU performance", so
let's disable TSO by default to regain the loss.

CC: stable <stable@vger.kernel.org>
Fixes: b10effb9 ("e1000e: fix buffer overrun while the I219 is processing DMA transactions")
BugLink: https://bugs.launchpad.net/bugs/1802691Signed-off-by: default avatarKai-Heng Feng <kai.heng.feng@canonical.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 0c80cdbf
...@@ -5294,6 +5294,10 @@ static void e1000_watchdog_task(struct work_struct *work) ...@@ -5294,6 +5294,10 @@ static void e1000_watchdog_task(struct work_struct *work)
/* oops */ /* oops */
break; break;
} }
if (hw->mac.type == e1000_pch_spt) {
netdev->features &= ~NETIF_F_TSO;
netdev->features &= ~NETIF_F_TSO6;
}
} }
/* enable transmits in the hardware, need to do this /* enable transmits in the hardware, need to do this
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment