Commit f3fd4cd5 authored by Michael Sprecher's avatar Michael Sprecher Committed by Greg Kroah-Hartman

Staging: et131x: fix most coding style issues in et131x

This is a patch to the et131x driver that fixes up almost all coding
style issues
Signed-off-by: default avatarMichael Sprecher <sprecher.m@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 67a7b378
...@@ -1052,7 +1052,7 @@ typedef struct _RXMAC_t { /* Location: */ ...@@ -1052,7 +1052,7 @@ typedef struct _RXMAC_t { /* Location: */
* 4-0: register * 4-0: register
*/ */
#define MII_ADDR(phy,reg) ((phy) << 8 | (reg)) #define MII_ADDR(phy, reg) ((phy) << 8 | (reg))
/* /*
* structure for MII Management Control reg in mac address map. * structure for MII Management Control reg in mac address map.
...@@ -1249,8 +1249,7 @@ typedef struct _MAC_t { /* Location: */ ...@@ -1249,8 +1249,7 @@ typedef struct _MAC_t { /* Location: */
/* /*
* MAC STATS Module of JAGCore Address Mapping * MAC STATS Module of JAGCore Address Mapping
*/ */
struct macstat_regs struct macstat_regs { /* Location: */
{ /* Location: */
u32 pad[32]; /* 0x6000 - 607C */ u32 pad[32]; /* 0x6000 - 607C */
/* Tx/Rx 0-64 Byte Frame Counter */ /* Tx/Rx 0-64 Byte Frame Counter */
......
...@@ -383,9 +383,9 @@ int et131x_init_eeprom(struct et131x_adapter *etdev) ...@@ -383,9 +383,9 @@ int et131x_init_eeprom(struct et131x_adapter *etdev)
/* This error could mean that there was an error /* This error could mean that there was an error
* reading the eeprom or that the eeprom doesn't exist. * reading the eeprom or that the eeprom doesn't exist.
* We will treat each case the same and not try to gather * We will treat each case the same and not try to
* additional information that normally would come from the * gather additional information that normally would
* eeprom, like MAC Address * come from the eeprom, like MAC Address
*/ */
etdev->has_eeprom = 0; etdev->has_eeprom = 0;
return -EIO; return -EIO;
......
...@@ -344,7 +344,7 @@ static void ET1310_PhyDuplexMode(struct et131x_adapter *etdev, u16 duplex) ...@@ -344,7 +344,7 @@ static void ET1310_PhyDuplexMode(struct et131x_adapter *etdev, u16 duplex)
static void ET1310_PhySpeedSelect(struct et131x_adapter *etdev, u16 speed) static void ET1310_PhySpeedSelect(struct et131x_adapter *etdev, u16 speed)
{ {
u16 data; u16 data;
static const u16 bits[3]={0x0000, 0x2000, 0x0040}; static const u16 bits[3] = {0x0000, 0x2000, 0x0040};
/* Read the PHY control register */ /* Read the PHY control register */
MiRead(etdev, PHY_CONTROL, &data); MiRead(etdev, PHY_CONTROL, &data);
......
...@@ -344,7 +344,7 @@ int et131x_rx_dma_memory_alloc(struct et131x_adapter *adapter) ...@@ -344,7 +344,7 @@ int et131x_rx_dma_memory_alloc(struct et131x_adapter *adapter)
"Cannot alloc memory for Packet Status Ring\n"); "Cannot alloc memory for Packet Status Ring\n");
return -ENOMEM; return -ENOMEM;
} }
printk("PSR %lx\n", (unsigned long) rx_ring->pPSRingPa); printk(KERN_INFO "PSR %lx\n", (unsigned long) rx_ring->pPSRingPa);
/* /*
* NOTE : pci_alloc_consistent(), used above to alloc DMA regions, * NOTE : pci_alloc_consistent(), used above to alloc DMA regions,
...@@ -363,7 +363,7 @@ int et131x_rx_dma_memory_alloc(struct et131x_adapter *adapter) ...@@ -363,7 +363,7 @@ int et131x_rx_dma_memory_alloc(struct et131x_adapter *adapter)
return -ENOMEM; return -ENOMEM;
} }
rx_ring->NumRfd = NIC_DEFAULT_NUM_RFD; rx_ring->NumRfd = NIC_DEFAULT_NUM_RFD;
printk("PRS %lx\n", (unsigned long)rx_ring->rx_status_bus); printk(KERN_INFO "PRS %lx\n", (unsigned long)rx_ring->rx_status_bus);
/* Recv /* Recv
* pci_pool_create initializes a lookaside list. After successful * pci_pool_create initializes a lookaside list. After successful
...@@ -841,8 +841,7 @@ PMP_RFD nic_rx_pkts(struct et131x_adapter *etdev) ...@@ -841,8 +841,7 @@ PMP_RFD nic_rx_pkts(struct et131x_adapter *etdev)
(rindex == 1 && (rindex == 1 &&
bindex > rx_local->Fbr1NumEntries - 1)) bindex > rx_local->Fbr1NumEntries - 1))
#else #else
if (rindex != 1 || if (rindex != 1 || bindex > rx_local->Fbr1NumEntries - 1)
bindex > rx_local->Fbr1NumEntries - 1)
#endif #endif
{ {
/* Illegal buffer or ring index cannot be used by S/W*/ /* Illegal buffer or ring index cannot be used by S/W*/
......
...@@ -91,8 +91,7 @@ ...@@ -91,8 +91,7 @@
#define ALCATEL_BROADCAST_PKT 0x02000000 #define ALCATEL_BROADCAST_PKT 0x02000000
/* typedefs for Free Buffer Descriptors */ /* typedefs for Free Buffer Descriptors */
struct fbr_desc struct fbr_desc {
{
u32 addr_lo; u32 addr_lo;
u32 addr_hi; u32 addr_hi;
u32 word2; /* Bits 10-31 reserved, 0-9 descriptor */ u32 word2; /* Bits 10-31 reserved, 0-9 descriptor */
......
...@@ -113,7 +113,13 @@ ...@@ -113,7 +113,13 @@
static u32 et131x_speed_set; static u32 et131x_speed_set;
module_param(et131x_speed_set, uint, 0); module_param(et131x_speed_set, uint, 0);
MODULE_PARM_DESC(et131x_speed_set, MODULE_PARM_DESC(et131x_speed_set,
"Set Link speed and dublex manually (0-5) [0] \n 1 : 10Mb Half-Duplex \n 2 : 10Mb Full-Duplex \n 3 : 100Mb Half-Duplex \n 4 : 100Mb Full-Duplex \n 5 : 1000Mb Full-Duplex \n 0 : Auto Speed Auto Dublex"); "Set Link speed and dublex manually (0-5) [0]\n \
1 : 10Mb Half-Duplex\n \
2 : 10Mb Full-Duplex\n \
3 : 100Mb Half-Duplex\n \
4 : 100Mb Full-Duplex\n \
5 : 1000Mb Full-Duplex\n \
0 : Auto Speed Auto Dublex");
/** /**
* et131x_hwaddr_init - set up the MAC Address on the ET1310 * et131x_hwaddr_init - set up the MAC Address on the ET1310
...@@ -558,7 +564,7 @@ static struct et131x_adapter *et131x_adapter_init(struct net_device *netdev, ...@@ -558,7 +564,7 @@ static struct et131x_adapter *et131x_adapter_init(struct net_device *netdev,
/* Parse configuration parameters into the private adapter struct */ /* Parse configuration parameters into the private adapter struct */
if (et131x_speed_set) if (et131x_speed_set)
dev_info(&etdev->pdev->dev, dev_info(&etdev->pdev->dev,
"Speed set manually to : %d \n", et131x_speed_set); "Speed set manually to : %d\n", et131x_speed_set);
etdev->SpeedDuplex = et131x_speed_set; etdev->SpeedDuplex = et131x_speed_set;
etdev->RegistryJumboPacket = 1514; /* 1514-9216 */ etdev->RegistryJumboPacket = 1514; /* 1514-9216 */
......
...@@ -426,26 +426,22 @@ void et131x_multicast(struct net_device *netdev) ...@@ -426,26 +426,22 @@ void et131x_multicast(struct net_device *netdev)
* accordingly * accordingly
*/ */
if (netdev->flags & IFF_PROMISC) { if (netdev->flags & IFF_PROMISC)
adapter->PacketFilter |= ET131X_PACKET_TYPE_PROMISCUOUS; adapter->PacketFilter |= ET131X_PACKET_TYPE_PROMISCUOUS;
} else { else
adapter->PacketFilter &= ~ET131X_PACKET_TYPE_PROMISCUOUS; adapter->PacketFilter &= ~ET131X_PACKET_TYPE_PROMISCUOUS;
}
if (netdev->flags & IFF_ALLMULTI) { if (netdev->flags & IFF_ALLMULTI)
adapter->PacketFilter |= ET131X_PACKET_TYPE_ALL_MULTICAST; adapter->PacketFilter |= ET131X_PACKET_TYPE_ALL_MULTICAST;
}
if (netdev_mc_count(netdev) > NIC_MAX_MCAST_LIST) { if (netdev_mc_count(netdev) > NIC_MAX_MCAST_LIST)
adapter->PacketFilter |= ET131X_PACKET_TYPE_ALL_MULTICAST; adapter->PacketFilter |= ET131X_PACKET_TYPE_ALL_MULTICAST;
}
if (netdev_mc_count(netdev) < 1) { if (netdev_mc_count(netdev) < 1) {
adapter->PacketFilter &= ~ET131X_PACKET_TYPE_ALL_MULTICAST; adapter->PacketFilter &= ~ET131X_PACKET_TYPE_ALL_MULTICAST;
adapter->PacketFilter &= ~ET131X_PACKET_TYPE_MULTICAST; adapter->PacketFilter &= ~ET131X_PACKET_TYPE_MULTICAST;
} else { } else
adapter->PacketFilter |= ET131X_PACKET_TYPE_MULTICAST; adapter->PacketFilter |= ET131X_PACKET_TYPE_MULTICAST;
}
/* Set values in the private adapter struct */ /* Set values in the private adapter struct */
i = 0; i = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment