Commit f4395b65 authored by Sebastian Ott's avatar Sebastian Ott Committed by James Bottomley

[SCSI] zfcp: proper use of device register

Don't use kfree directly after device registration started.
Signed-off-by: default avatarSebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: default avatarChristof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 24680def
...@@ -309,8 +309,10 @@ struct zfcp_unit *zfcp_unit_enqueue(struct zfcp_port *port, u64 fcp_lun) ...@@ -309,8 +309,10 @@ struct zfcp_unit *zfcp_unit_enqueue(struct zfcp_port *port, u64 fcp_lun)
} }
read_unlock_irq(&zfcp_data.config_lock); read_unlock_irq(&zfcp_data.config_lock);
if (device_register(&unit->sysfs_device)) if (device_register(&unit->sysfs_device)) {
goto err_out_free; put_device(&unit->sysfs_device);
return ERR_PTR(-EINVAL);
}
if (sysfs_create_group(&unit->sysfs_device.kobj, if (sysfs_create_group(&unit->sysfs_device.kobj,
&zfcp_sysfs_unit_attrs)) { &zfcp_sysfs_unit_attrs)) {
...@@ -675,8 +677,10 @@ struct zfcp_port *zfcp_port_enqueue(struct zfcp_adapter *adapter, u64 wwpn, ...@@ -675,8 +677,10 @@ struct zfcp_port *zfcp_port_enqueue(struct zfcp_adapter *adapter, u64 wwpn,
} }
read_unlock_irq(&zfcp_data.config_lock); read_unlock_irq(&zfcp_data.config_lock);
if (device_register(&port->sysfs_device)) if (device_register(&port->sysfs_device)) {
goto err_out_free; put_device(&port->sysfs_device);
goto err_out;
}
retval = sysfs_create_group(&port->sysfs_device.kobj, retval = sysfs_create_group(&port->sysfs_device.kobj,
&zfcp_sysfs_port_attrs); &zfcp_sysfs_port_attrs);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment