Commit f57c4bbf authored by Dan Carpenter's avatar Dan Carpenter Committed by Marcel Holtmann

6lowpan: Off by one handling ->nexthdr

NEXTHDR_MAX is 255.  What happens here is that we take a u8 value
"hdr->nexthdr" from the network and then look it up in
lowpan_nexthdr_nhcs[].  The problem is that if hdr->nexthdr is 0xff then
we read one element beyond the end of the array so the array needs to
be one element larger.

Fixes: 92aa7c65 ("6lowpan: add generic nhc layer interface")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarJukka Rissanen <jukka.rissanen@linux.intel.com>
Acked-by: default avatarAlexander Aring <aring@mojatatu.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 50357261
...@@ -18,7 +18,7 @@ ...@@ -18,7 +18,7 @@
#include "nhc.h" #include "nhc.h"
static struct rb_root rb_root = RB_ROOT; static struct rb_root rb_root = RB_ROOT;
static struct lowpan_nhc *lowpan_nexthdr_nhcs[NEXTHDR_MAX]; static struct lowpan_nhc *lowpan_nexthdr_nhcs[NEXTHDR_MAX + 1];
static DEFINE_SPINLOCK(lowpan_nhc_lock); static DEFINE_SPINLOCK(lowpan_nhc_lock);
static int lowpan_nhc_insert(struct lowpan_nhc *nhc) static int lowpan_nhc_insert(struct lowpan_nhc *nhc)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment