Commit f7503230 authored by Julia Lawall's avatar Julia Lawall Committed by John W. Linville

drivers/net/wireless/mwifiex/scan.c: test the just-initialized value

Test the just-initialized value rather than some other one.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier x,y,f!={PTR_ERR,ERR_PTR,ERR_CAST};
statement S;
@@

x = f(...);
(
if (\(x == NULL\|IS_ERR(x)\)) S
|
*if (\(y == NULL\|IS_ERR(y)\))
 { ... when != x
   return ...; }
)
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 8b0be90c
...@@ -1480,8 +1480,8 @@ mwifiex_update_curr_bss_params(struct mwifiex_private *priv, ...@@ -1480,8 +1480,8 @@ mwifiex_update_curr_bss_params(struct mwifiex_private *priv,
return -ENOMEM; return -ENOMEM;
} }
beacon_ie = kzalloc(ie_len, GFP_KERNEL); beacon_ie = kzalloc(ie_len, GFP_KERNEL);
if (!bss_desc) { if (!beacon_ie) {
dev_err(priv->adapter->dev, " failed to alloc bss_desc\n"); dev_err(priv->adapter->dev, " failed to alloc beacon_ie\n");
return -ENOMEM; return -ENOMEM;
} }
memcpy(beacon_ie, ie_buf, ie_len); memcpy(beacon_ie, ie_buf, ie_len);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment