Commit f8765177 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

Revert "staging: greybus: remove multiple blank lines"

This reverts commit fcb733b5.

Johan writes:
	This patch removes the double newlines that were used as section
	headers in the lengthy protocol header file, and therefore hurts
	readability.

So I'm reverting it.
Reported-by: default avatarJohan Hovold <johan@kernel.org>
Cc: Ioannis Valasakis <code@wizofe.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e0f7d41e
...@@ -65,6 +65,7 @@ ...@@ -65,6 +65,7 @@
#define GB_CONTROL_BUNDLE_ID 0 #define GB_CONTROL_BUNDLE_ID 0
#define GB_CONTROL_CPORT_ID 0 #define GB_CONTROL_CPORT_ID 0
/* /*
* All operation messages (both requests and responses) begin with * All operation messages (both requests and responses) begin with
* a header that encodes the size of the message (header included). * a header that encodes the size of the message (header included).
...@@ -94,6 +95,7 @@ struct gb_operation_msg_hdr { ...@@ -94,6 +95,7 @@ struct gb_operation_msg_hdr {
__u8 pad[2]; /* must be zero (ignore when read) */ __u8 pad[2]; /* must be zero (ignore when read) */
} __packed; } __packed;
/* Generic request types */ /* Generic request types */
#define GB_REQUEST_TYPE_CPORT_SHUTDOWN 0x00 #define GB_REQUEST_TYPE_CPORT_SHUTDOWN 0x00
#define GB_REQUEST_TYPE_INVALID 0x7f #define GB_REQUEST_TYPE_INVALID 0x7f
...@@ -102,6 +104,7 @@ struct gb_cport_shutdown_request { ...@@ -102,6 +104,7 @@ struct gb_cport_shutdown_request {
__u8 phase; __u8 phase;
} __packed; } __packed;
/* Control Protocol */ /* Control Protocol */
/* Greybus control request types */ /* Greybus control request types */
...@@ -246,6 +249,7 @@ struct gb_apb_request_cport_flags { ...@@ -246,6 +249,7 @@ struct gb_apb_request_cport_flags {
#define GB_APB_CPORT_FLAG_HIGH_PRIO 0x02 #define GB_APB_CPORT_FLAG_HIGH_PRIO 0x02
} __packed; } __packed;
/* Firmware Download Protocol */ /* Firmware Download Protocol */
/* Request Types */ /* Request Types */
...@@ -282,6 +286,7 @@ struct gb_fw_download_release_firmware_request { ...@@ -282,6 +286,7 @@ struct gb_fw_download_release_firmware_request {
} __packed; } __packed;
/* firmware download release firmware response has no payload */ /* firmware download release firmware response has no payload */
/* Firmware Management Protocol */ /* Firmware Management Protocol */
/* Request Types */ /* Request Types */
...@@ -363,6 +368,7 @@ struct gb_fw_mgmt_backend_fw_updated_request { ...@@ -363,6 +368,7 @@ struct gb_fw_mgmt_backend_fw_updated_request {
} __packed; } __packed;
/* firmware management backend firmware updated response has no payload */ /* firmware management backend firmware updated response has no payload */
/* Component Authentication Protocol (CAP) */ /* Component Authentication Protocol (CAP) */
/* Request Types */ /* Request Types */
...@@ -399,6 +405,7 @@ struct gb_cap_authenticate_response { ...@@ -399,6 +405,7 @@ struct gb_cap_authenticate_response {
__u8 signature[0]; __u8 signature[0];
} __packed; } __packed;
/* Bootrom Protocol */ /* Bootrom Protocol */
/* Version of the Greybus bootrom protocol we support */ /* Version of the Greybus bootrom protocol we support */
...@@ -467,6 +474,7 @@ struct gb_bootrom_get_vid_pid_response { ...@@ -467,6 +474,7 @@ struct gb_bootrom_get_vid_pid_response {
__le32 product_id; __le32 product_id;
} __packed; } __packed;
/* Power Supply */ /* Power Supply */
/* Greybus power supply request types */ /* Greybus power supply request types */
...@@ -640,6 +648,7 @@ struct gb_power_supply_event_request { ...@@ -640,6 +648,7 @@ struct gb_power_supply_event_request {
#define GB_POWER_SUPPLY_UPDATE 0x01 #define GB_POWER_SUPPLY_UPDATE 0x01
} __packed; } __packed;
/* HID */ /* HID */
/* Greybus HID operation types */ /* Greybus HID operation types */
...@@ -685,6 +694,7 @@ struct gb_hid_input_report_request { ...@@ -685,6 +694,7 @@ struct gb_hid_input_report_request {
__u8 report[0]; __u8 report[0];
} __packed; } __packed;
/* I2C */ /* I2C */
/* Greybus i2c request types */ /* Greybus i2c request types */
...@@ -720,6 +730,7 @@ struct gb_i2c_transfer_response { ...@@ -720,6 +730,7 @@ struct gb_i2c_transfer_response {
__u8 data[0]; /* inbound data */ __u8 data[0]; /* inbound data */
} __packed; } __packed;
/* GPIO */ /* GPIO */
/* Greybus GPIO request types */ /* Greybus GPIO request types */
...@@ -818,6 +829,7 @@ struct gb_gpio_irq_event_request { ...@@ -818,6 +829,7 @@ struct gb_gpio_irq_event_request {
} __packed; } __packed;
/* irq event has no response */ /* irq event has no response */
/* PWM */ /* PWM */
/* Greybus PWM operation types */ /* Greybus PWM operation types */
...@@ -1305,6 +1317,7 @@ struct gb_svc_intf_oops_request { ...@@ -1305,6 +1317,7 @@ struct gb_svc_intf_oops_request {
} __packed; } __packed;
/* intf_oops response has no payload */ /* intf_oops response has no payload */
/* RAW */ /* RAW */
/* Greybus raw request types */ /* Greybus raw request types */
...@@ -1315,6 +1328,7 @@ struct gb_raw_send_request { ...@@ -1315,6 +1328,7 @@ struct gb_raw_send_request {
__u8 data[0]; __u8 data[0];
} __packed; } __packed;
/* UART */ /* UART */
/* Greybus UART operation types */ /* Greybus UART operation types */
...@@ -2190,6 +2204,7 @@ struct gb_audio_send_data_request { ...@@ -2190,6 +2204,7 @@ struct gb_audio_send_data_request {
__u8 data[0]; __u8 data[0];
} __packed; } __packed;
/* Log */ /* Log */
/* operations */ /* operations */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment