Commit f8b81e05 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown

spi: dln2: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230303172041.2103336-21-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent d1a9fa8a
...@@ -781,7 +781,7 @@ static int dln2_spi_probe(struct platform_device *pdev) ...@@ -781,7 +781,7 @@ static int dln2_spi_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int dln2_spi_remove(struct platform_device *pdev) static void dln2_spi_remove(struct platform_device *pdev)
{ {
struct spi_master *master = platform_get_drvdata(pdev); struct spi_master *master = platform_get_drvdata(pdev);
struct dln2_spi *dln2 = spi_master_get_devdata(master); struct dln2_spi *dln2 = spi_master_get_devdata(master);
...@@ -790,8 +790,6 @@ static int dln2_spi_remove(struct platform_device *pdev) ...@@ -790,8 +790,6 @@ static int dln2_spi_remove(struct platform_device *pdev)
if (dln2_spi_enable(dln2, false) < 0) if (dln2_spi_enable(dln2, false) < 0)
dev_err(&pdev->dev, "Failed to disable SPI module\n"); dev_err(&pdev->dev, "Failed to disable SPI module\n");
return 0;
} }
#ifdef CONFIG_PM_SLEEP #ifdef CONFIG_PM_SLEEP
...@@ -873,7 +871,7 @@ static struct platform_driver spi_dln2_driver = { ...@@ -873,7 +871,7 @@ static struct platform_driver spi_dln2_driver = {
.pm = &dln2_spi_pm, .pm = &dln2_spi_pm,
}, },
.probe = dln2_spi_probe, .probe = dln2_spi_probe,
.remove = dln2_spi_remove, .remove_new = dln2_spi_remove,
}; };
module_platform_driver(spi_dln2_driver); module_platform_driver(spi_dln2_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment