Commit fc63c5b1 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Hans Verkuil

media: vivid-core: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 1727b716
...@@ -2021,7 +2021,7 @@ static int vivid_probe(struct platform_device *pdev) ...@@ -2021,7 +2021,7 @@ static int vivid_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int vivid_remove(struct platform_device *pdev) static void vivid_remove(struct platform_device *pdev)
{ {
struct vivid_dev *dev; struct vivid_dev *dev;
unsigned int i, j; unsigned int i, j;
...@@ -2101,7 +2101,6 @@ static int vivid_remove(struct platform_device *pdev) ...@@ -2101,7 +2101,6 @@ static int vivid_remove(struct platform_device *pdev)
v4l2_device_put(&dev->v4l2_dev); v4l2_device_put(&dev->v4l2_dev);
vivid_devs[i] = NULL; vivid_devs[i] = NULL;
} }
return 0;
} }
static void vivid_pdev_release(struct device *dev) static void vivid_pdev_release(struct device *dev)
...@@ -2115,7 +2114,7 @@ static struct platform_device vivid_pdev = { ...@@ -2115,7 +2114,7 @@ static struct platform_device vivid_pdev = {
static struct platform_driver vivid_pdrv = { static struct platform_driver vivid_pdrv = {
.probe = vivid_probe, .probe = vivid_probe,
.remove = vivid_remove, .remove_new = vivid_remove,
.driver = { .driver = {
.name = "vivid", .name = "vivid",
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment