Commit ff5d3a97 authored by Eric Biggers's avatar Eric Biggers Committed by Theodore Ts'o

fscrypt: remove WARN_ON_ONCE() when decryption fails

If decrypting a block fails, fscrypt did a WARN_ON_ONCE().  But WARN is
meant for kernel bugs, which this isn't; this could be hit by fuzzers
using fault injection, for example.  Also, there is already a proper
warning message logged in fscrypt_do_page_crypto(), so the WARN doesn't
add much.

Just remove the unnessary WARN.
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent cd0265fc
...@@ -37,12 +37,10 @@ static void __fscrypt_decrypt_bio(struct bio *bio, bool done) ...@@ -37,12 +37,10 @@ static void __fscrypt_decrypt_bio(struct bio *bio, bool done)
int ret = fscrypt_decrypt_page(page->mapping->host, page, int ret = fscrypt_decrypt_page(page->mapping->host, page,
PAGE_SIZE, 0, page->index); PAGE_SIZE, 0, page->index);
if (ret) { if (ret)
WARN_ON_ONCE(1);
SetPageError(page); SetPageError(page);
} else if (done) { else if (done)
SetPageUptodate(page); SetPageUptodate(page);
}
if (done) if (done)
unlock_page(page); unlock_page(page);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment