Commit ff69ec96 authored by Charles Keepax's avatar Charles Keepax Committed by Mark Brown

ASoC: tscs454: Add endianness flag in snd_soc_component_driver

The endianness flag is used on the CODEC side to specify an
ambivalence to endian, typically because it is lost over the hardware
link. This device receives audio over an I2S DAI and as such should
have endianness applied.

A fixup is also required to use the width directly rather than relying
on the format in hw_params, now both little and big endian would be
supported. It is worth noting this changes the behaviour of S24_LE to
use a word length of 24 rather than 32. This would appear to be a
correction since the fact S24_LE is stored as 32 bits should not be
presented over the bus.
Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220504170905.332415-26-ckeepax@opensource.cirrus.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent f5e0084b
...@@ -3120,18 +3120,17 @@ static int set_aif_sample_format(struct snd_soc_component *component, ...@@ -3120,18 +3120,17 @@ static int set_aif_sample_format(struct snd_soc_component *component,
unsigned int width; unsigned int width;
int ret; int ret;
switch (format) { switch (snd_pcm_format_width(format)) {
case SNDRV_PCM_FORMAT_S16_LE: case 16:
width = FV_WL_16; width = FV_WL_16;
break; break;
case SNDRV_PCM_FORMAT_S20_3LE: case 20:
width = FV_WL_20; width = FV_WL_20;
break; break;
case SNDRV_PCM_FORMAT_S24_3LE: case 24:
width = FV_WL_24; width = FV_WL_24;
break; break;
case SNDRV_PCM_FORMAT_S24_LE: case 32:
case SNDRV_PCM_FORMAT_S32_LE:
width = FV_WL_32; width = FV_WL_32;
break; break;
default: default:
...@@ -3326,6 +3325,7 @@ static const struct snd_soc_component_driver soc_component_dev_tscs454 = { ...@@ -3326,6 +3325,7 @@ static const struct snd_soc_component_driver soc_component_dev_tscs454 = {
.num_dapm_routes = ARRAY_SIZE(tscs454_intercon), .num_dapm_routes = ARRAY_SIZE(tscs454_intercon),
.controls = tscs454_snd_controls, .controls = tscs454_snd_controls,
.num_controls = ARRAY_SIZE(tscs454_snd_controls), .num_controls = ARRAY_SIZE(tscs454_snd_controls),
.endianness = 1,
}; };
#define TSCS454_RATES SNDRV_PCM_RATE_8000_96000 #define TSCS454_RATES SNDRV_PCM_RATE_8000_96000
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment